[PR #365] [MERGED] Overhaul: Qemu Network interfaces. #421

New issue

Closed

opened 2026-02-28 00:42:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/365
Author: @Tinyblargon
Created: 9/16/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @Tinyblargon

Base: master ← Head: #341

📝 Commits (10+)

c8e6d6a refactor: remove typecasts
674867f feat: vlan type
9a3802b feat: MTU type
74f3db4 add test coverage to gitignore
4ee1619 refactor: move QemuNetworkInterfaceID to seperate file
bbd2171 feat: introduce QemuNetworkInterfaces
103f4de feat: qemu network mapToAPI
ec73853 feat: qemu network mapToSDK
55f5829 feat: qemu network Validate
c246f25 refactor: replace magic number with constant

📊 Changes

18 files changed (+1733 additions, -303 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 proxmox/config_qemu.go (+56 -208)
📝 proxmox/config_qemu_cloudinit.go (+11 -11)
📝 proxmox/config_qemu_disk.go (+25 -25)
📝 proxmox/config_qemu_guestagent.go (+3 -3)
➕ proxmox/config_qemu_network.go (+534 -0)
➕ proxmox/config_qemu_network_test.go (+345 -0)
📝 proxmox/config_qemu_test.go (+528 -19)
📝 proxmox/config_qemu_tpm.go (+1 -1)
➕ proxmox/type_mtu.go (+14 -0)
➕ proxmox/type_mtu_test.go (+33 -0)
➕ proxmox/type_vlan(s).go (+54 -0)
➕ proxmox/type_vlan(s)_test.go (+75 -0)
📝 proxmox/util.go (+2 -2)
📝 proxmox/util_test.go (+2 -2)
📝 test/api/CloudInit/shared_test.go (+16 -16)
📝 test/api/Qemu/shared_test.go (+14 -16)
➕ test/data/test_data_mtu/type_mtu.go (+17 -0)

📄 Description

Closes #341

Re-implements the Qemu Network interfaces.

100% code coverage.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/365 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#341` --- ### 📝 Commits (10+) - [`c8e6d6a`](https://github.com/Telmate/proxmox-api-go/commit/c8e6d6a82b259c7cfbca7dacdfc54f0b4f7abe74) refactor: remove typecasts - [`674867f`](https://github.com/Telmate/proxmox-api-go/commit/674867f1faf9ebd0a06dcf21100ba9ed08ab37ad) feat: vlan type - [`9a3802b`](https://github.com/Telmate/proxmox-api-go/commit/9a3802bf7f7946ba497ad1c80a2687919c8f7c75) feat: MTU type - [`74f3db4`](https://github.com/Telmate/proxmox-api-go/commit/74f3db4f1a0808ea193b0333f17860d6a1c4aef2) add test coverage to gitignore - [`4ee1619`](https://github.com/Telmate/proxmox-api-go/commit/4ee1619e3d62d77e9006bc7bc9d67ad3a78dbe2f) refactor: move `QemuNetworkInterfaceID` to seperate file - [`bbd2171`](https://github.com/Telmate/proxmox-api-go/commit/bbd217153902e7f4d9be0027537b9b7563481d21) feat: introduce `QemuNetworkInterfaces` - [`103f4de`](https://github.com/Telmate/proxmox-api-go/commit/103f4dec30fb98a30dae2077e2421ace5e13e56b) feat: qemu network `mapToAPI` - [`ec73853`](https://github.com/Telmate/proxmox-api-go/commit/ec738538e2c143d2f3a85aa2da869dd867cd69bc) feat: qemu network `mapToSDK` - [`55f5829`](https://github.com/Telmate/proxmox-api-go/commit/55f5829eaedbc5a8a6c5ae8e0daf9b0f3b03c13b) feat: qemu network `Validate` - [`c246f25`](https://github.com/Telmate/proxmox-api-go/commit/c246f250745df27b5380a6341e40b9664ac886a4) refactor: replace magic number with constant ### 📊 Changes **18 files changed** (+1733 additions, -303 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `proxmox/config_qemu.go` (+56 -208) 📝 `proxmox/config_qemu_cloudinit.go` (+11 -11) 📝 `proxmox/config_qemu_disk.go` (+25 -25) 📝 `proxmox/config_qemu_guestagent.go` (+3 -3) ➕ `proxmox/config_qemu_network.go` (+534 -0) ➕ `proxmox/config_qemu_network_test.go` (+345 -0) 📝 `proxmox/config_qemu_test.go` (+528 -19) 📝 `proxmox/config_qemu_tpm.go` (+1 -1) ➕ `proxmox/type_mtu.go` (+14 -0) ➕ `proxmox/type_mtu_test.go` (+33 -0) ➕ `proxmox/type_vlan(s).go` (+54 -0) ➕ `proxmox/type_vlan(s)_test.go` (+75 -0) 📝 `proxmox/util.go` (+2 -2) 📝 `proxmox/util_test.go` (+2 -2) 📝 `test/api/CloudInit/shared_test.go` (+16 -16) 📝 `test/api/Qemu/shared_test.go` (+14 -16) ➕ `test/data/test_data_mtu/type_mtu.go` (+17 -0) </details> ### 📄 Description Closes #341 Re-implements the Qemu Network interfaces. 100% code coverage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>