[PR #408] [MERGED] Fix: sshkey set when empty #448

New issue

Closed

opened 2026-02-28 00:42:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/408
Author: @Tinyblargon
Created: 3/26/2025
Status: ✅ Merged
Merged: 3/26/2025
Merged by: @Tinyblargon

Base: master ← Head: fix-ssh-empty

📝 Commits (2)

870b2ef test: add missing cases
4ea00c6 fix: empty key not set properly

📊 Changes

4 files changed (+39 additions, -5 deletions)

View changed files

📝 proxmox/config_qemu_cloudinit.go (+9 -2)
📝 proxmox/config_qemu_test.go (+7 -0)
📝 proxmox/type_authorizedkey.go (+5 -1)
📝 proxmox/type_authorizedkey_test.go (+18 -2)

📄 Description

Fixes and issue where the ssh key will be set even when a list of empty keys is provided.
It would add an escaped \n for every empty key.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/408 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 3/26/2025 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `fix-ssh-empty` --- ### 📝 Commits (2) - [`870b2ef`](https://github.com/Telmate/proxmox-api-go/commit/870b2ef8c33f7940d2b38986a88db2c2deb53012) test: add missing cases - [`4ea00c6`](https://github.com/Telmate/proxmox-api-go/commit/4ea00c615915b699d079a4230b2f9c7b2b13f940) fix: empty key not set properly ### 📊 Changes **4 files changed** (+39 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu_cloudinit.go` (+9 -2) 📝 `proxmox/config_qemu_test.go` (+7 -0) 📝 `proxmox/type_authorizedkey.go` (+5 -1) 📝 `proxmox/type_authorizedkey_test.go` (+18 -2) </details> ### 📄 Description Fixes and issue where the ssh key will be set even when a list of empty keys is provided. It would add an escaped `\n` for every empty key. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>