[PR #349] [MERGED] Overhaul: Memory #408

New issue

Closed

opened 2026-02-28 00:42:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/349
Author: @Tinyblargon
Created: 7/27/2024
Status: ✅ Merged
Merged: 7/27/2024
Merged by: @Tinyblargon

Base: master ← Head: memory

📝 Commits (6)

603a2c5 test: add baseConfig for memory
3a5fe97 refactor: sort alphabetically
e4dc5ca refactor: add baseConfig
f1d62ee feat: int & uint parsers
4098fd3 feat: memory mapping
b6d5422 feat: memory validator

📊 Changes

9 files changed (+1578 additions, -886 deletions)

View changed files

📝 .github/workflows/go.yml (+1 -1)
➕ internal/parse/parse.go (+31 -0)
➕ internal/parse/parse_test.go (+79 -0)
📝 proxmox/config_qemu.go (+34 -39)
➕ proxmox/config_qemu_memory.go (+165 -0)
➕ proxmox/config_qemu_memory_test.go (+221 -0)
📝 proxmox/config_qemu_test.go (+1045 -844)
📝 test/api/CloudInit/shared_test.go (+1 -1)
📝 test/api/Qemu/shared_test.go (+1 -1)

📄 Description

Moved all memory related settings in QemuMemory
Added validation logic.
Added unit tests

PR is so big due to unit-test refactoring.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/349 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 7/27/2024 **Status:** ✅ Merged **Merged:** 7/27/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `memory` --- ### 📝 Commits (6) - [`603a2c5`](https://github.com/Telmate/proxmox-api-go/commit/603a2c523c46de03480a555e4bee05c4a7a0a613) test: add baseConfig for memory - [`3a5fe97`](https://github.com/Telmate/proxmox-api-go/commit/3a5fe97891c6071dda9e5caf7eaf5d1b247930c5) refactor: sort alphabetically - [`e4dc5ca`](https://github.com/Telmate/proxmox-api-go/commit/e4dc5cab9523b0d6906f47cad891e15a475d5d17) refactor: add `baseConfig` - [`f1d62ee`](https://github.com/Telmate/proxmox-api-go/commit/f1d62ee47c5a2be85206618867be911f152e1804) feat: int & uint parsers - [`4098fd3`](https://github.com/Telmate/proxmox-api-go/commit/4098fd3df40820f63973ca665f31449828c1b666) feat: memory mapping - [`b6d5422`](https://github.com/Telmate/proxmox-api-go/commit/b6d5422ffd5cb74611de43e84fd89b53d1d28c41) feat: memory validator ### 📊 Changes **9 files changed** (+1578 additions, -886 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/go.yml` (+1 -1) ➕ `internal/parse/parse.go` (+31 -0) ➕ `internal/parse/parse_test.go` (+79 -0) 📝 `proxmox/config_qemu.go` (+34 -39) ➕ `proxmox/config_qemu_memory.go` (+165 -0) ➕ `proxmox/config_qemu_memory_test.go` (+221 -0) 📝 `proxmox/config_qemu_test.go` (+1045 -844) 📝 `test/api/CloudInit/shared_test.go` (+1 -1) 📝 `test/api/Qemu/shared_test.go` (+1 -1) </details> ### 📄 Description - Moved all memory related settings in `QemuMemory` - Added validation logic. - Added unit tests PR is so big due to unit-test refactoring. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>