[PR #399] [MERGED] feat: type `GuestID` #440

New issue

Closed

opened 2026-02-28 00:42:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/399
Author: @Tinyblargon
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @Tinyblargon

Base: master ← Head: GuestID

📝 Commits (4)

7cf4d0b feat: type GuestID
ac832bf refactor: rename VmID to ID
01127c8 refactor: use GuestID for disk code
b433e36 refactor: rename constant

📊 Changes

34 files changed (+263 additions, -184 deletions)

View changed files

📝 cli/command/create/create-snapshot.go (+1 -1)
📝 cli/command/create/guest/create-guest.go (+2 -3)
📝 cli/command/delete/delete-guest.go (+2 -4)
📝 cli/command/delete/delete-snapshot.go (+1 -1)
📝 cli/command/get/guest/get-guest-config.go (+1 -1)
📝 cli/command/get/guest/get-guest-feature.go (+1 -1)
📝 cli/command/get/id/get-id-check.go (+3 -3)
📝 cli/command/guest/guest-rollback.go (+1 -1)
📝 cli/command/guest/guest-shutdown.go (+1 -1)
📝 cli/command/guest/guest-start.go (+1 -1)
📝 cli/command/guest/guest-status.go (+1 -1)
📝 cli/command/guest/guest-stop.go (+1 -1)
📝 cli/command/guest/guest-uptime.go (+1 -1)
📝 cli/command/guest/qemu/guest-qemu-hibernate.go (+1 -1)
📝 cli/command/guest/qemu/guest-qemu-pause.go (+1 -1)
📝 cli/command/guest/qemu/guest-qemu-reset.go (+1 -1)
📝 cli/command/guest/qemu/guest-qemu-resume.go (+1 -1)
📝 cli/command/list/list-snapshots.go (+1 -1)
📝 cli/command/update/update-snapshotdescription.go (+1 -1)
📝 cli/print.go (+3 -1)

...and 14 more files

📄 Description

Added the GuestID type for the vmid.
This type has validation as the id has a limited valid range.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/399 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `GuestID` --- ### 📝 Commits (4) - [`7cf4d0b`](https://github.com/Telmate/proxmox-api-go/commit/7cf4d0b56038cdf03ac3ba0b62acb16d29f0cc28) feat: type `GuestID` - [`ac832bf`](https://github.com/Telmate/proxmox-api-go/commit/ac832bf7c4463e19bb8e187e98c49ab7cb5b9716) refactor: rename `VmID` to `ID` - [`01127c8`](https://github.com/Telmate/proxmox-api-go/commit/01127c89539c213ec265a9b4c158a1a5cabe30df) refactor: use `GuestID` for disk code - [`b433e36`](https://github.com/Telmate/proxmox-api-go/commit/b433e368a4e90b765b04f71c4db9a1bebb8fa429) refactor: rename constant ### 📊 Changes **34 files changed** (+263 additions, -184 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/create/create-snapshot.go` (+1 -1) 📝 `cli/command/create/guest/create-guest.go` (+2 -3) 📝 `cli/command/delete/delete-guest.go` (+2 -4) 📝 `cli/command/delete/delete-snapshot.go` (+1 -1) 📝 `cli/command/get/guest/get-guest-config.go` (+1 -1) 📝 `cli/command/get/guest/get-guest-feature.go` (+1 -1) 📝 `cli/command/get/id/get-id-check.go` (+3 -3) 📝 `cli/command/guest/guest-rollback.go` (+1 -1) 📝 `cli/command/guest/guest-shutdown.go` (+1 -1) 📝 `cli/command/guest/guest-start.go` (+1 -1) 📝 `cli/command/guest/guest-status.go` (+1 -1) 📝 `cli/command/guest/guest-stop.go` (+1 -1) 📝 `cli/command/guest/guest-uptime.go` (+1 -1) 📝 `cli/command/guest/qemu/guest-qemu-hibernate.go` (+1 -1) 📝 `cli/command/guest/qemu/guest-qemu-pause.go` (+1 -1) 📝 `cli/command/guest/qemu/guest-qemu-reset.go` (+1 -1) 📝 `cli/command/guest/qemu/guest-qemu-resume.go` (+1 -1) 📝 `cli/command/list/list-snapshots.go` (+1 -1) 📝 `cli/command/update/update-snapshotdescription.go` (+1 -1) 📝 `cli/print.go` (+3 -1) _...and 14 more files_ </details> ### 📄 Description Added the `GuestID` type for the vmid. This type has validation as the id has a limited valid range. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>