[PR #329] [MERGED] Re-implement: agent interface information #399

New issue

Closed

opened 2026-02-28 00:42:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/329
Author: @Tinyblargon
Created: 4/24/2024
Status: ✅ Merged
Merged: 5/13/2024
Merged by: @Tinyblargon

Base: master ← Head: feat#328

📝 Commits (6)

2e330cd feat: allow checking for extra errors
69dcb19 refactor: move type to different file
c964b1f refactor: get AgentNetworkInterface
dd561f4 test: AgentNetworkInterface{}
df9fdb3 Mark as deprecated
dfa6aa5 Remove unused code

📊 Changes

5 files changed (+270 additions, -60 deletions)

View changed files

📝 proxmox/client.go (+13 -53)
📝 proxmox/config_qemu.go (+0 -7)
➕ proxmox/data_qemu_agent.go (+83 -0)
➕ proxmox/data_qemu_agent_test.go (+173 -0)
📝 proxmox/session.go (+1 -0)

📄 Description

Make

Reworked json unmarshaling, (it was the only place in the code base that was done differently).
Made code testable.
made code part of the VmRef struct.

Fixes #328

Will make a pull to fix this in terraform as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/329 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 4/24/2024 **Status:** ✅ Merged **Merged:** 5/13/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `feat#328` --- ### 📝 Commits (6) - [`2e330cd`](https://github.com/Telmate/proxmox-api-go/commit/2e330cd96a4eb6216df2a097a8d9bfe51d55adcb) feat: allow checking for extra errors - [`69dcb19`](https://github.com/Telmate/proxmox-api-go/commit/69dcb19bd824f54cd36d198d72fda82648c9f3a6) refactor: move type to different file - [`c964b1f`](https://github.com/Telmate/proxmox-api-go/commit/c964b1febede66cd21b7560993b8f588ede2a51b) refactor: get `AgentNetworkInterface` - [`dd561f4`](https://github.com/Telmate/proxmox-api-go/commit/dd561f41d8f6c58e695bef43f3c4daf663a16909) test: `AgentNetworkInterface{}` - [`df9fdb3`](https://github.com/Telmate/proxmox-api-go/commit/df9fdb357708ddc6c59014a717f2b03fabec739e) Mark as deprecated - [`dfa6aa5`](https://github.com/Telmate/proxmox-api-go/commit/dfa6aa53334aa164c7b2646acfce492771200515) Remove unused code ### 📊 Changes **5 files changed** (+270 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+13 -53) 📝 `proxmox/config_qemu.go` (+0 -7) ➕ `proxmox/data_qemu_agent.go` (+83 -0) ➕ `proxmox/data_qemu_agent_test.go` (+173 -0) 📝 `proxmox/session.go` (+1 -0) </details> ### 📄 Description Make - Reworked json unmarshaling, (it was the only place in the code base that was done differently). - Made code testable. - made code part of the `VmRef` struct. Fixes #328 Will make a pull to fix this in terraform as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>