[PR #354] [MERGED] Overhaul: `QemuCPU` #412

New issue

Closed

opened 2026-02-28 00:42:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/354
Author: @Tinyblargon
Created: 8/13/2024
Status: ✅ Merged
Merged: 8/15/2024
Merged by: @Tinyblargon

Base: master ← Head: #318

📝 Commits (10+)

82dd199 refactor: move cores into QemuCPU
74ccaf9 refactor: move numa to QemuCPU
57bb9b0 refactor: move Sockets to QemuCPU
bc5510c refactor: move vCPU to QemuCPU
a24ba9a test: base QemuCPU
5abb198 refactor: doesn't have to be pointer
87206c6 feat: max version to use during tests
8e6e018 feat: reimplement cpu type
d75c74e feat: CpuUnits
000d0d7 feat: QemuCPU.Affinity

📊 Changes

14 files changed (+2057 additions, -77 deletions)

View changed files

📝 .github/workflows/go.yml (+3 -3)
📝 cli/command/create/guest/create-guest.go (+23 -6)
📝 go.mod (+1 -1)
📝 internal/util/util.go (+1 -0)
📝 proxmox/client.go (+19 -0)
📝 proxmox/client_test.go (+32 -0)
📝 proxmox/config_qemu.go (+20 -49)
➕ proxmox/config_qemu_cpu.go (+754 -0)
➕ proxmox/config_qemu_cpu_test.go (+455 -0)
📝 proxmox/config_qemu_test.go (+545 -0)
➕ proxmox/type_tribool.go (+64 -0)
➕ proxmox/type_tribool_test.go (+118 -0)
📝 test/api/CloudInit/shared_test.go (+11 -9)
📝 test/api/Qemu/shared_test.go (+11 -9)

📄 Description

re-implements all qemu cpu options and supports all pve8.2 cpu options.
100% test coverage.

closes #318

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/354 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 8/13/2024 **Status:** ✅ Merged **Merged:** 8/15/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#318` --- ### 📝 Commits (10+) - [`82dd199`](https://github.com/Telmate/proxmox-api-go/commit/82dd1991c4746b4eb41f65eaca65766ef9a8413c) refactor: move cores into `QemuCPU` - [`74ccaf9`](https://github.com/Telmate/proxmox-api-go/commit/74ccaf905d488c6923d5c41ff43b123d30fab549) refactor: move numa to `QemuCPU` - [`57bb9b0`](https://github.com/Telmate/proxmox-api-go/commit/57bb9b0cebd4026d98cc7e10b4df62d1dc2d233b) refactor: move Sockets to `QemuCPU` - [`bc5510c`](https://github.com/Telmate/proxmox-api-go/commit/bc5510ca6a16322bf1a364b5852801ed146bab8b) refactor: move vCPU to `QemuCPU` - [`a24ba9a`](https://github.com/Telmate/proxmox-api-go/commit/a24ba9a3424fd7d6db5310498fc301685e99fa58) test: base `QemuCPU` - [`5abb198`](https://github.com/Telmate/proxmox-api-go/commit/5abb19877dc7c31d093a68e16306de83949d09fa) refactor: doesn't have to be pointer - [`87206c6`](https://github.com/Telmate/proxmox-api-go/commit/87206c69bd4f180eb61a8f1bfbba7d42d103ff9d) feat: max version to use during tests - [`8e6e018`](https://github.com/Telmate/proxmox-api-go/commit/8e6e018c029320fa061bf764b00f15b2256b3d84) feat: reimplement cpu type - [`d75c74e`](https://github.com/Telmate/proxmox-api-go/commit/d75c74ed5456f4afc823a2bfc24d55c66f74cbcb) feat: `CpuUnits` - [`000d0d7`](https://github.com/Telmate/proxmox-api-go/commit/000d0d78b9d77f5a9a83280c6fa0dab9eb4e3419) feat: `QemuCPU.Affinity` ### 📊 Changes **14 files changed** (+2057 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/go.yml` (+3 -3) 📝 `cli/command/create/guest/create-guest.go` (+23 -6) 📝 `go.mod` (+1 -1) 📝 `internal/util/util.go` (+1 -0) 📝 `proxmox/client.go` (+19 -0) 📝 `proxmox/client_test.go` (+32 -0) 📝 `proxmox/config_qemu.go` (+20 -49) ➕ `proxmox/config_qemu_cpu.go` (+754 -0) ➕ `proxmox/config_qemu_cpu_test.go` (+455 -0) 📝 `proxmox/config_qemu_test.go` (+545 -0) ➕ `proxmox/type_tribool.go` (+64 -0) ➕ `proxmox/type_tribool_test.go` (+118 -0) 📝 `test/api/CloudInit/shared_test.go` (+11 -9) 📝 `test/api/Qemu/shared_test.go` (+11 -9) </details> ### 📄 Description re-implements all qemu cpu options and supports all pve8.2 cpu options. 100% test coverage. closes #318 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>