[PR #219] [MERGED] BugFix: sshKeys not encoded properly #318

New issue

Closed

opened 2026-02-28 00:41:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/219
Author: @Tinyblargon
Created: 11/29/2022
Status: ✅ Merged
Merged: 12/1/2022
Merged by: @mleone87

Base: master ← Head: Hotfix

📝 Commits (3)

8250315 refactor: move ssh key encoding into function.
afc256c test: added a test for ssh key encoding
4a37592 fix: fix ':' in ssh key not encoded properly

📊 Changes

2 files changed (+45 additions, -5 deletions)

View changed files

📝 proxmox/config_qemu.go (+11 -5)
➕ proxmox/config_qemu_test.go (+34 -0)

📄 Description

Fix for https://github.com/Telmate/proxmox-api-go/issues/218

Work done:

Moved ssh key encoding logic into its own function.
Added test for testing the ssh key encofing.
Fixed bug where the : symbol would not be encoded.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/219 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 11/29/2022 **Status:** ✅ Merged **Merged:** 12/1/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `Hotfix` --- ### 📝 Commits (3) - [`8250315`](https://github.com/Telmate/proxmox-api-go/commit/82503156b36a1d4298b213745c2b3078392aa68e) refactor: move ssh key encoding into function. - [`afc256c`](https://github.com/Telmate/proxmox-api-go/commit/afc256ccd45e5c15247468027e0874ff411aebd1) test: added a test for ssh key encoding - [`4a37592`](https://github.com/Telmate/proxmox-api-go/commit/4a3759202f42b7e5d61f0a2b3f393114b94948da) fix: fix ':' in ssh key not encoded properly ### 📊 Changes **2 files changed** (+45 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+11 -5) ➕ `proxmox/config_qemu_test.go` (+34 -0) </details> ### 📄 Description Fix for https://github.com/Telmate/proxmox-api-go/issues/218 Work done: - Moved ssh key encoding logic into its own function. - Added test for testing the ssh key encofing. - Fixed bug where the `:` symbol would not be encoded. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>