[PR #298] [CLOSED] [FIX] cloudinit disk not set fix #380

New issue

Closed

opened 2026-02-28 00:41:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/298
Author: @mleone87
Created: 1/19/2024
Status: ❌ Closed

Base: master ← Head: issue-901-fix

📝 Commits (2)

8a9113d [FIX] cloudinit disk not set fix
19d4a3a merges changes

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 proxmox/config_qemu.go (+4 -0)

📄 Description

This should fix the issue described in https://github.com/Telmate/terraform-provider-proxmox/issues/901

There is certainly a case that can be not managed by this code, for example when you define a cloudint disk and you remove it but in the remote config is still present and it will be overwritten. But I cannot see a case where one would do this, cloudinit disks are a special thing in Proxmox

looking forward for test and suggestions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/298 **Author:** [@mleone87](https://github.com/mleone87) **Created:** 1/19/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue-901-fix` --- ### 📝 Commits (2) - [`8a9113d`](https://github.com/Telmate/proxmox-api-go/commit/8a9113d80c4f7a7d9c2e62dfdcca707995c02c24) [FIX] cloudinit disk not set fix - [`19d4a3a`](https://github.com/Telmate/proxmox-api-go/commit/19d4a3a1c193890f9043596eeccd002d144c62ad) merges changes ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+4 -0) </details> ### 📄 Description This should fix the issue described in https://github.com/Telmate/terraform-provider-proxmox/issues/901 There is certainly a case that can be not managed by this code, for example when you define a cloudint disk and you remove it but in the remote config is still present and it will be overwritten. But I cannot see a case where one would do this, cloudinit disks are a special thing in Proxmox looking forward for test and suggestions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>