[PR #191] [MERGED] Cli overhaul: guest id (no tests yet) #298

New issue

Closed

opened 2026-02-28 00:41:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/191
Author: @Tinyblargon
Created: 9/7/2022
Status: ✅ Merged
Merged: 9/10/2022
Merged by: @mleone87

Base: master ← Head: CLI-Overhaul

📝 Commits (5)

05ebf80 Make fuction public
3ff1d87 reinplement VMIdExists fuction
1a74fee Add commands to get id information
1c4e8dc fix variable name
ed4e42a Reinplement broken legacy command

📊 Changes

16 files changed (+155 additions, -32 deletions)

View changed files

📝 cli/command/commands/commands.go (+2 -1)
📝 cli/command/get/get-acmeaccount.go (+1 -1)
📝 cli/command/get/get-metricserver.go (+1 -1)
📝 cli/command/get/get-pool.go (+3 -2)
📝 cli/command/get/get-storage.go (+1 -1)
📝 cli/command/get/get-user.go (+1 -1)
📝 cli/command/get/get.go (+3 -3)
➕ cli/command/get/id/get-id-check.go (+31 -0)
➕ cli/command/get/id/get-id-max.go (+27 -0)
➕ cli/command/get/id/get-id-next.go (+26 -0)
➕ cli/command/get/id/get-id.go (+15 -0)
📝 cli/validate.go (+12 -4)
📝 main.go (+10 -4)
📝 proxmox/client.go (+16 -0)
📝 proxmox/config_qemu.go (+3 -10)
📝 test/cli/preperations.go (+3 -4)

📄 Description

Another pull for https://github.com/Telmate/proxmox-api-go/issues/171

Work so far:

Made the commands for getting id inforamation.
Reimplemented the VMIdExists function to not rely on proxmox returning an error. this fuction is not used by the terraform provider so this change should't break anything there.
Reinplemented the legacy idstatus command as the new VMIdExists function broke this.

No tests yet for these command as they are dependent on the CRUD operations of LXC and Qemu which haven't been implemented yet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/191 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 9/7/2022 **Status:** ✅ Merged **Merged:** 9/10/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `CLI-Overhaul` --- ### 📝 Commits (5) - [`05ebf80`](https://github.com/Telmate/proxmox-api-go/commit/05ebf80943a68c767d962a22e48f8026404ee77a) Make fuction public - [`3ff1d87`](https://github.com/Telmate/proxmox-api-go/commit/3ff1d8766daf5d84db6655301b4d564764f2543f) reinplement VMIdExists fuction - [`1a74fee`](https://github.com/Telmate/proxmox-api-go/commit/1a74fee7e3b11be5a882683bc3607c680b072237) Add commands to get id information - [`1c4e8dc`](https://github.com/Telmate/proxmox-api-go/commit/1c4e8dc9880953033ecb1300305de047c8b73b27) fix variable name - [`ed4e42a`](https://github.com/Telmate/proxmox-api-go/commit/ed4e42adb0c78b3787a1f66cbe13ce0a3916a62f) Reinplement broken legacy command ### 📊 Changes **16 files changed** (+155 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/commands/commands.go` (+2 -1) 📝 `cli/command/get/get-acmeaccount.go` (+1 -1) 📝 `cli/command/get/get-metricserver.go` (+1 -1) 📝 `cli/command/get/get-pool.go` (+3 -2) 📝 `cli/command/get/get-storage.go` (+1 -1) 📝 `cli/command/get/get-user.go` (+1 -1) 📝 `cli/command/get/get.go` (+3 -3) ➕ `cli/command/get/id/get-id-check.go` (+31 -0) ➕ `cli/command/get/id/get-id-max.go` (+27 -0) ➕ `cli/command/get/id/get-id-next.go` (+26 -0) ➕ `cli/command/get/id/get-id.go` (+15 -0) 📝 `cli/validate.go` (+12 -4) 📝 `main.go` (+10 -4) 📝 `proxmox/client.go` (+16 -0) 📝 `proxmox/config_qemu.go` (+3 -10) 📝 `test/cli/preperations.go` (+3 -4) </details> ### 📄 Description Another pull for https://github.com/Telmate/proxmox-api-go/issues/171 Work so far: - Made the commands for getting id inforamation. - Reimplemented the VMIdExists function to not rely on proxmox returning an error. this fuction is not used by the terraform provider so this change should't break anything there. - Reinplemented the legacy `idstatus` command as the new VMIdExists function broke this. No tests yet for these command as they are dependent on the CRUD operations of LXC and Qemu which haven't been implemented yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>