[PR #292] [MERGED] fix: Disk incorrectly formatted with `lvm` back-end #377

New issue

Closed

opened 2026-02-28 00:41:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/292
Author: @Tinyblargon
Created: 1/3/2024
Status: ✅ Merged
Merged: 1/4/2024
Merged by: @mleone87

Base: master ← Head: BugFix-DiskFormat

📝 Commits (4)

953450a fix: disk format can be optional
02f3404 fix: add missing support for disk syntax
ccd9e2c fix: disk incorrectly formatted for lvm storage
af11eb2 fix: node not set causes disk migration

📊 Changes

8 files changed (+1066 additions, -108 deletions)

View changed files

📝 proxmox/config_qemu.go (+2 -1)
📝 proxmox/config_qemu_disk.go (+120 -46)
📝 proxmox/config_qemu_disk_ide.go (+3 -0)
📝 proxmox/config_qemu_disk_sata.go (+3 -0)
📝 proxmox/config_qemu_disk_scsi.go (+3 -0)
📝 proxmox/config_qemu_disk_test.go (+151 -2)
📝 proxmox/config_qemu_disk_virtio.go (+3 -0)
📝 proxmox/config_qemu_test.go (+781 -59)

📄 Description

Ran into a bug where the disk format was returned empty by the library.

Apparently the lvm, and file storage back-ends use different syntax for the disks:

file: storage:100/vm-100-disk-0.raw
lvm: storage:vm-100-disk-0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/292 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 1/3/2024 **Status:** ✅ Merged **Merged:** 1/4/2024 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `BugFix-DiskFormat` --- ### 📝 Commits (4) - [`953450a`](https://github.com/Telmate/proxmox-api-go/commit/953450a906b408cc3dbcf196a3c5bf499ed61dd5) fix: disk format can be optional - [`02f3404`](https://github.com/Telmate/proxmox-api-go/commit/02f34049005252e384b6ba82d641d91bce07a397) fix: add missing support for disk syntax - [`ccd9e2c`](https://github.com/Telmate/proxmox-api-go/commit/ccd9e2c9d5357de8bb615e10d169e935ce8e4c6e) fix: disk incorrectly formatted for lvm storage - [`af11eb2`](https://github.com/Telmate/proxmox-api-go/commit/af11eb2f59353382a606d0353be0c1afca06dbf7) fix: node not set causes disk migration ### 📊 Changes **8 files changed** (+1066 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+2 -1) 📝 `proxmox/config_qemu_disk.go` (+120 -46) 📝 `proxmox/config_qemu_disk_ide.go` (+3 -0) 📝 `proxmox/config_qemu_disk_sata.go` (+3 -0) 📝 `proxmox/config_qemu_disk_scsi.go` (+3 -0) 📝 `proxmox/config_qemu_disk_test.go` (+151 -2) 📝 `proxmox/config_qemu_disk_virtio.go` (+3 -0) 📝 `proxmox/config_qemu_test.go` (+781 -59) </details> ### 📄 Description Ran into a bug where the disk format was returned empty by the library. Apparently the lvm, and file storage back-ends use different syntax for the disks: - file: `storage:100/vm-100-disk-0.raw` - lvm: `storage:vm-100-disk-0` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>