[PR #185] [MERGED] Add a simpler disk creation method #292

New issue

Closed

opened 2026-02-28 00:41:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/185
Author: @jqueuniet
Created: 7/12/2022
Status: ✅ Merged
Merged: 7/12/2022
Merged by: @mleone87

Base: master ← Head: disk_creation

📝 Commits (1)

950ced1 Add a simpler disk creation method

📊 Changes

1 file changed (+17 additions, -0 deletions)

View changed files

📝 proxmox/client.go (+17 -0)

📄 Description

This PR might be somewhat controversial as creating a disk is already implemented by the client method CreateVMDisk. However, as a direct client user, I found it confusing to use, somewhat tailored for the Terraform use-case where the full config is applied each time and asking a lot of parameters like the disk full path and the disk slot which aren't necessary using the qemu/<vmid>/config endpoint.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/185 **Author:** [@jqueuniet](https://github.com/jqueuniet) **Created:** 7/12/2022 **Status:** ✅ Merged **Merged:** 7/12/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `disk_creation` --- ### 📝 Commits (1) - [`950ced1`](https://github.com/Telmate/proxmox-api-go/commit/950ced1fd54a1c893389e252b9806e39956f855a) Add a simpler disk creation method ### 📊 Changes **1 file changed** (+17 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+17 -0) </details> ### 📄 Description This PR might be somewhat controversial as creating a disk is already implemented by the client method `CreateVMDisk`. However, as a direct client user, I found it confusing to use, somewhat tailored for the Terraform use-case where the full config is applied each time and asking a lot of parameters like the disk full path and the disk slot which aren't necessary using the `qemu/<vmid>/config` endpoint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>