[PR #288] [MERGED] Fix #286 #375

New issue

Closed

opened 2026-02-28 00:41:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/288
Author: @Tinyblargon
Created: 12/7/2023
Status: ✅ Merged
Merged: 12/7/2023
Merged by: @mleone87

Base: master ← Head: Fix#286

📝 Commits (3)

3cf7815 fix: code got reverted during pull request
1fe88e4 fix: use literal string
1164f40 fix: error strings should not be capitalized (ST1005)

📊 Changes

3 files changed (+4 additions, -232 deletions)

View changed files

📝 main.go (+2 -2)
📝 proxmox/config_qemu.go (+1 -229)
📝 proxmox/util.go (+1 -1)

📄 Description

This should Fix #286

I've figured out what happened.

The code that was moved to ConfigQemu{}.mapToStruct() in c0f97853fb was added back to NewConfigQemuFromApi(vmr *VmRef, client *Client), this commit 3cf781571b removes the duplicate code.
A regex wasn't properly escaped 1fe88e42c7.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/288 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 12/7/2023 **Status:** ✅ Merged **Merged:** 12/7/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `Fix#286` --- ### 📝 Commits (3) - [`3cf7815`](https://github.com/Telmate/proxmox-api-go/commit/3cf781571ba7ad3de5457557ffff921b30136ac2) fix: code got reverted during pull request - [`1fe88e4`](https://github.com/Telmate/proxmox-api-go/commit/1fe88e42c74171c845a37da0dd177daf6747ba33) fix: use literal string - [`1164f40`](https://github.com/Telmate/proxmox-api-go/commit/1164f401c59ed4f2890b9d663b293603021da7c7) fix: error strings should not be capitalized (ST1005) ### 📊 Changes **3 files changed** (+4 additions, -232 deletions) <details> <summary>View changed files</summary> 📝 `main.go` (+2 -2) 📝 `proxmox/config_qemu.go` (+1 -229) 📝 `proxmox/util.go` (+1 -1) </details> ### 📄 Description This should Fix #286 I've figured out what happened. - The code that was moved to `ConfigQemu{}.mapToStruct()` in c0f97853fbc42a763e7bcc6df811772f1e6d0287 was added back to `NewConfigQemuFromApi(vmr *VmRef, client *Client)`, this commit 3cf781571ba7ad3de5457557ffff921b30136ac2 removes the duplicate code. - A regex wasn't properly escaped 1fe88e42c74171c845a37da0dd177daf6747ba33. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>