[PR #178] [MERGED] Cli overhaul: MetricServer #288

New issue

Closed

opened 2026-02-28 00:41:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/178
Author: @Tinyblargon
Created: 5/9/2022
Status: ✅ Merged
Merged: 5/10/2022
Merged by: @mleone87

Base: master ← Head: CLI-Overhaul

📝 Commits (4)

371c810 Add: set metricserver Command
0292b0e Add: get metricserver Command
41a4cbc Changed how values are mapped to api
ca862cc Integration Test: MetricServer

📊 Changes

10 files changed (+830 additions, -11 deletions)

View changed files

➕ cli/command/get/get-metricserver.go (+17 -0)
📝 cli/command/get/get.go (+2 -0)
➕ cli/command/set/set-metricserver.go (+34 -0)
📝 proxmox/config_metrics.go (+19 -11)
➕ test/cli/MetricServers/MetricServer_Errors_test.go (+167 -0)
➕ test/cli/MetricServers/MetricServer_Graphite_0_test.go (+107 -0)
➕ test/cli/MetricServers/MetricServer_Graphite_1_test.go (+109 -0)
➕ test/cli/MetricServers/MetricServer_InfluxDB_0_test.go (+134 -0)
➕ test/cli/MetricServers/MetricServer_InfluxDB_1_test.go (+122 -0)
➕ test/cli/MetricServers/MetricServer_InfluxDB_2_test.go (+119 -0)

📄 Description

Another pull for #171

Work so far:

Created all the commands for the metricserver function.
Created integration tests for metricserver function.

Made minor changes to how the metricserver feature maps the struct values to the api, as it had some unintended behavior and bugs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/178 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 5/9/2022 **Status:** ✅ Merged **Merged:** 5/10/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `CLI-Overhaul` --- ### 📝 Commits (4) - [`371c810`](https://github.com/Telmate/proxmox-api-go/commit/371c810fd239dce33992df68c34c548380d35235) Add: set metricserver Command - [`0292b0e`](https://github.com/Telmate/proxmox-api-go/commit/0292b0e38e2b24b3bb29ba55bb0352f7e62287b4) Add: get metricserver Command - [`41a4cbc`](https://github.com/Telmate/proxmox-api-go/commit/41a4cbc9767153133a251844c22e2ec1effd9bfa) Changed how values are mapped to api - [`ca862cc`](https://github.com/Telmate/proxmox-api-go/commit/ca862ccb75c9b6dadbd3e75ff6f6ada7907529b2) Integration Test: MetricServer ### 📊 Changes **10 files changed** (+830 additions, -11 deletions) <details> <summary>View changed files</summary> ➕ `cli/command/get/get-metricserver.go` (+17 -0) 📝 `cli/command/get/get.go` (+2 -0) ➕ `cli/command/set/set-metricserver.go` (+34 -0) 📝 `proxmox/config_metrics.go` (+19 -11) ➕ `test/cli/MetricServers/MetricServer_Errors_test.go` (+167 -0) ➕ `test/cli/MetricServers/MetricServer_Graphite_0_test.go` (+107 -0) ➕ `test/cli/MetricServers/MetricServer_Graphite_1_test.go` (+109 -0) ➕ `test/cli/MetricServers/MetricServer_InfluxDB_0_test.go` (+134 -0) ➕ `test/cli/MetricServers/MetricServer_InfluxDB_1_test.go` (+122 -0) ➕ `test/cli/MetricServers/MetricServer_InfluxDB_2_test.go` (+119 -0) </details> ### 📄 Description Another pull for #171 Work so far: - Created all the commands for the metricserver function. - Created integration tests for metricserver function. Made minor changes to how the metricserver feature maps the struct values to the api, as it had some unintended behavior and bugs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>