[PR #266] [MERGED] Phase out: GetVmList() #355

New issue

Closed

opened 2026-02-28 00:41:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/266
Author: @Tinyblargon
Created: 6/7/2023
Status: ✅ Merged
Merged: 6/8/2023
Merged by: @mleone87

Base: master ← Head: Deprecate-GetVmList

📝 Commits (3)

226571f refactor: move error check lower in the call stack
3d9eaac refactor: better code reuse
13cf13f Update TODO

📊 Changes

2 files changed (+11 additions, -15 deletions)

View changed files

📝 proxmox/client.go (+10 -13)
📝 proxmox/config_qemu.go (+1 -2)

📄 Description

Started phasing out GetVmList()

GetVmList() is replaced with GetResourceList(resourceListGuest) in all but one instance (its only used in the old cli).
Added error checking when extracting the array to GetItemListInterfaceArray().
Minor code optimization due to using GetResourceList(resourceListGuest).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/266 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 6/7/2023 **Status:** ✅ Merged **Merged:** 6/8/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `Deprecate-GetVmList` --- ### 📝 Commits (3) - [`226571f`](https://github.com/Telmate/proxmox-api-go/commit/226571fb60c6b2635e63bf6c5842e6a231db5dbd) refactor: move error check lower in the call stack - [`3d9eaac`](https://github.com/Telmate/proxmox-api-go/commit/3d9eaac812a455a3bddefb20019396542e96e283) refactor: better code reuse - [`13cf13f`](https://github.com/Telmate/proxmox-api-go/commit/13cf13f57b45116a679c263ecb3d0966371e86aa) Update TODO ### 📊 Changes **2 files changed** (+11 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+10 -13) 📝 `proxmox/config_qemu.go` (+1 -2) </details> ### 📄 Description Started phasing out `GetVmList()` - `GetVmList()` is replaced with `GetResourceList(resourceListGuest)` in all but one instance (its only used in the old cli). - Added error checking when extracting the array to `GetItemListInterfaceArray()`. - Minor code optimization due to using `GetResourceList(resourceListGuest)`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>