[PR #152] [MERGED] fix(CreateVm): Make 'ide2' not hardcoded assumption #266

New issue

Closed

opened 2026-02-28 00:41:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/152
Author: @sygibson
Created: 1/7/2022
Status: ✅ Merged
Merged: 1/7/2022
Merged by: @mleone87

Base: master ← Head: fix-ide2-in-CreateVm

📝 Commits (1)

06b2d55 fix(CreateVm): Make 'ide2' not hardcoded assumption

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 proxmox/config_qemu.go (+4 -1)

📄 Description

In the proxmox/config_qemu.go code path, the QemuIso is specified as a hard coded assumption (see #151 ) for the CreateVm call. This does not allow for other VM creation scenarios that do not need or require the ISO be used or specified.

This pull request moves the ide2 Param definition out of the params map, and in to a separate optional if check structure. This allows for the create of a VM resource without the ISO definition in the config. Existing use cases will continue to function without modification, with the ISO definition in the config.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/152 **Author:** [@sygibson](https://github.com/sygibson) **Created:** 1/7/2022 **Status:** ✅ Merged **Merged:** 1/7/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `fix-ide2-in-CreateVm` --- ### 📝 Commits (1) - [`06b2d55`](https://github.com/Telmate/proxmox-api-go/commit/06b2d5593457af71ee57042450947b7053ebff32) fix(CreateVm): Make 'ide2' not hardcoded assumption ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+4 -1) </details> ### 📄 Description In the `proxmox/config_qemu.go` code path, the `QemuIso` is specified as a hard coded assumption (see #151 ) for the `CreateVm` call. This does not allow for other VM creation scenarios that do not need or require the ISO be used or specified. This pull request moves the `ide2` Param definition out of the params map, and in to a separate optional `if` check structure. This allows for the create of a VM resource without the ISO definition in the config. Existing use cases will continue to function without modification, with the ISO definition in the config. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>