template (#260) #350

New issue

Closed

opened 2026-02-28 00:41:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/261
Author: @chrisbenincasa
Created: 5/11/2023
Status: ✅ Merged
Merged: 5/14/2023
Merged by: @mleone87

Base: master ← Head: 260

📝 Commits (1)

90253b9 Fix POST /nodes/{node}/lxc/{id}/template

📊 Changes

2 files changed (+16 additions, -1 deletions)

View changed files

📝 proxmox/client.go (+3 -1)
📝 test/api/Lxc/lxc_create_update_delete_test.go (+13 -0)

📄 Description

Fixes #260 by ignoring empty exit statuses in CreateTemplate if the vmType == "lxc".

This should be safe to ignore given that the API specifically returns null in the success case: https://pve.proxmox.com/pve-docs/api-viewer/#/nodes/{node}/lxc/{vmid}/template

See issue for example request/response.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/261 **Author:** [@chrisbenincasa](https://github.com/chrisbenincasa) **Created:** 5/11/2023 **Status:** ✅ Merged **Merged:** 5/14/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `260` --- ### 📝 Commits (1) - [`90253b9`](https://github.com/Telmate/proxmox-api-go/commit/90253b9aeb74487967fa48843add5fc33c0c17e1) Fix POST /nodes/{node}/lxc/{id}/template ### 📊 Changes **2 files changed** (+16 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+3 -1) 📝 `test/api/Lxc/lxc_create_update_delete_test.go` (+13 -0) </details> ### 📄 Description Fixes #260 by ignoring empty exit statuses in CreateTemplate if the vmType == "lxc". This should be safe to ignore given that the API specifically returns null in the success case: https://pve.proxmox.com/pve-docs/api-viewer/#/nodes/{node}/lxc/{vmid}/template See issue for example request/response. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>