mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 23:45:55 +03:00
[PR #142] [MERGED] Implement HA Group setting #260
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#260
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/142
Author: @RubenHoms
Created: 10/22/2021
Status: ✅ Merged
Merged: 10/22/2021
Merged by: @ggongaware
Base:
master← Head:master📝 Commits (1)
8173ecaImplement HA Group setting📊 Changes
3 files changed (+19 additions, -8 deletions)
View changed files
📝
proxmox/client.go(+12 -3)📝
proxmox/config_lxc.go(+4 -3)📝
proxmox/config_qemu.go(+3 -2)📄 Description
This change will implement the HA Group setting. We could already define the HA State (running, stopped, etc.) but with this change it'll be possible to also set what HA Group a resource should belong to.
I successfully tested this on my own proxmox instance by forking the proxmox provider and changing the scheme to accept the HA Group parameter. I wanted to merge it back here first before I open a pull request on the
terraform-provider-proxmoxrepo to ensure nothing breaks.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.