[GH-ISSUE #496] meta: state of the cli #135

Open
opened 2026-02-28 00:40:42 +03:00 by kerem · 2 comments
Owner

Originally created by @NemoDacremont on GitHub (Oct 29, 2025).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/496

When I worked on the README, I realized that some features were missing from the new CLI and were only present on the legacy one. I think the state of the CLI is confusing, and it would be better to only have the new one.

We discussed redesigning the public interface of the client, I actually changed my mind and think the interface you proposed is really interesting, but I think it would be time-consuming. Redesigning the public interface would help new user working on the project, however I think the CLI is also a good way to understand how the SDK works, and having it up to date and clear is important to this end.

I think I'll try to work a little bit on this before going back to SDNs for the terraform provider, what do you think about migrating the legacy CLI to the new one @Tinyblargon ? Is it possible to remove the legacy CLI, or may it risk breaking things ?

  • #497
  • migrate: add set acmeplugin to the new CLI
  • #517
  • migrate: getNetworkInterfaces to get guest networkinterfaces
  • migrate: installQemu to guest install
  • migrate: cloneQemu to guest clone
  • migrate: sshforward to ssh
  • migrate: sshbackward to ssh
  • migrate: sendstring to guest sendstring
  • migrate: migrate to guest migrate
  • #515
  • #513
  • migrate: updateAcmeAccountEmail to update acmeaccount
  • #500
  • #503
  • #504
  • #508

I'll edit this post with the other migration tasks.

Originally created by @NemoDacremont on GitHub (Oct 29, 2025). Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/496 When I worked on the README, I realized that some features were missing from the new CLI and were only present on the legacy one. I think the state of the CLI is confusing, and it would be better to only have the new one. We discussed redesigning the public interface of the client, I actually changed my mind and think the interface you proposed is really interesting, but I think it would be time-consuming. Redesigning the public interface would help new user working on the project, however I think the CLI is also a good way to understand how the SDK works, and having it up to date and clear is important to this end. I think I'll try to work a little bit on this before going back to SDNs for the terraform provider, what do you think about migrating the legacy CLI to the new one @Tinyblargon ? Is it possible to remove the legacy CLI, or may it risk breaking things ? - [x] #497 - [x] migrate: add set acmeplugin to the new CLI - [x] #517 - [ ] migrate: getNetworkInterfaces to `get guest networkinterfaces` - [ ] migrate: installQemu to `guest install` - [ ] migrate: cloneQemu to `guest clone` - [ ] migrate: sshforward to `ssh` - [ ] migrate: sshbackward to `ssh` - [ ] migrate: sendstring to `guest sendstring` - [ ] migrate: migrate to `guest migrate` - [x] #515 - [x] #513 - [ ] migrate: updateAcmeAccountEmail to `update acmeaccount` - [x] #500 - [x] #503 - [x] #504 - [x] #508 I'll edit this post with the other migration tasks.
Author
Owner

@Tinyblargon commented on GitHub (Oct 29, 2025):

@NemoDacremont with the old CLI, we should switch the flag, make the legacy one opt-in. It would also be a good moment to start with a 0.0.0 and start shipping binaries of the CLI.

For refactoring the public interferences. I effectively have about four howers of "dead time" due to work travel with public transit. I try to do the boring busy work of the codebase during that time.

As for the SDN feature, we will have to go through a few rounds of review with the public interfaces as it's a really complex feature.

<!-- gh-comment-id:3462589334 --> @Tinyblargon commented on GitHub (Oct 29, 2025): @NemoDacremont with the old CLI, we should switch the flag, make the legacy one opt-in. It would also be a good moment to start with a `0.0.0` and start shipping binaries of the CLI. For refactoring the public interferences. I effectively have about four howers of "dead time" due to work travel with public transit. I try to do the boring busy work of the codebase during that time. As for the SDN feature, we will have to go through a few rounds of review with the public interfaces as it's a really complex feature.
Author
Owner

@NemoDacremont commented on GitHub (Oct 29, 2025):

ok, then if that's fine with you I'll go ahead and start migrating the features to the new cli in small PR if possible, once that's done i'll make the legacy CLI opt in.

<!-- gh-comment-id:3462702045 --> @NemoDacremont commented on GitHub (Oct 29, 2025): ok, then if that's fine with you I'll go ahead and start migrating the features to the new cli in small PR if possible, once that's done i'll make the legacy CLI opt in.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#135
No description provided.