[PR #27] [CLOSED] start downloading the largest file right away with select, matching peerflix #377

New issue

Closed

opened 2026-03-15 03:30:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 03:30:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asapach/peerflix-server/pull/27
Author: @ryanramage
Created: 3/3/2015
Status: ❌ Closed

Base: master ← Head: select-file

📝 Commits (2)

0d6201d start downloading the largest file right away with select, matching peerflix
fcf65bf simplify choosing the file to select

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 server/store.js (+8 -0)

📄 Description

Peerflix uses file.select() to begin downloading the largest file when the engine is ready. This can be seen here:

https://github.com/mafintosh/peerflix/blob/master/index.js#L36-L48

Select is documented here

https://github.com/mafintosh/torrent-stream#fileselect

This changes the behaviour of peerflix-server, so if you don't want this, I can modify this pull request to have a feature switch that resides in the config file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asapach/peerflix-server/pull/27 **Author:** [@ryanramage](https://github.com/ryanramage) **Created:** 3/3/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `select-file` --- ### 📝 Commits (2) - [`0d6201d`](https://github.com/asapach/peerflix-server/commit/0d6201dac38026fffd5e83bb7591d24a3da7b8f2) start downloading the largest file right away with select, matching peerflix - [`fcf65bf`](https://github.com/asapach/peerflix-server/commit/fcf65bfa463de822999191448e849a1828f19583) simplify choosing the file to select ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/store.js` (+8 -0) </details> ### 📄 Description Peerflix uses file.select() to begin downloading the largest file when the engine is ready. This can be seen here: https://github.com/mafintosh/peerflix/blob/master/index.js#L36-L48 Select is documented here https://github.com/mafintosh/torrent-stream#fileselect This changes the behaviour of peerflix-server, so if you don't want this, I can modify this pull request to have a feature switch that resides in the config file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>