[GH-ISSUE #173] Built-in block list ? #356

New issue

Open

opened 2026-03-15 03:07:22 +03:00 by kerem · 4 comments

kerem commented

2026-03-15 03:07:22 +03:00

Owner

Originally created by @Coriou on GitHub (Nov 4, 2019).
Original GitHub issue: https://github.com/asapach/peerflix-server/issues/173

I think it'd be great to have sensible block list defaults. I've looked at the block list implementation in torrent-stream which is kinda meh.

I think it'd make sense to implement the block list at this application's level. I've prototyped an implementation using blocklist-ipsets which works nicely. It introduces no external dependencies and uses torrent-stream's "block" feature.

What I'm not sure about though is should we pull the IP list at each engine load (potentially overkill really) or do we have a script loading the IPs periodically to block and saving them to a file locally ?

Thoughts ?

Here's a demo implementation

Originally created by @Coriou on GitHub (Nov 4, 2019). Original GitHub issue: https://github.com/asapach/peerflix-server/issues/173 I think it'd be great to have sensible block list defaults. I've looked at the block list implementation in [torrent-stream](https://github.com/mafintosh/torrent-stream/blob/master/index.js#L118) which is kinda meh. I think it'd make sense to implement the block list at this application's level. I've prototyped an implementation using [blocklist-ipsets](https://github.com/firehol/blocklist-ipsets) which works nicely. It introduces no external dependencies and uses `torrent-stream`'s "block" feature. What I'm not sure about though is should we pull the IP list at each engine load (potentially overkill really) or do we have a script loading the IPs periodically to block and saving them to a file locally ? Thoughts ? [Here's a demo implementation](https://github.com/Coriou/peerflix-server/commit/452bc3ab95cd4ad47fc72ad2bd4a631b74a1649c)

kerem added the

enhancement

label

2026-03-15 03:07:22 +03:00

kerem commented

2026-03-15 03:07:42 +03:00

Author

Owner

@asapach commented on GitHub (Nov 5, 2019):

I'd rather keep it simple and let the users provide their own blocklist file. This could be done by convention: e.g. on start we look for the file called ~/.config/peerflix-server/blocklist; if it exists we parse it and pass to torrent-stream. Optionally we could watch for the file changes and update as necessary, if there is an external process which updates the file.

@asapach commented on GitHub (Nov 5, 2019): I'd rather keep it simple and let the users provide their own blocklist file. This could be done by convention: e.g. on start we look for the file called `~/.config/peerflix-server/blocklist`; if it exists we parse it and pass to `torrent-stream`. Optionally we could watch for the file changes and update as necessary, if there is an external process which updates the file.

kerem commented

2026-03-15 03:07:47 +03:00

Author

Owner

@Coriou commented on GitHub (Nov 5, 2019):

Sounds good to me ! I'll work on it, maybe tomorrow, should be easy enough.

Should we ship a default blocklist ?

@Coriou commented on GitHub (Nov 5, 2019): Sounds good to me ! I'll work on it, maybe tomorrow, should be easy enough. Should we ship a default blocklist ?

kerem commented

2026-03-15 03:07:52 +03:00

Author

Owner

@asapach commented on GitHub (Nov 5, 2019):

Should we ship a default blocklist ?

Only if there is one which is relatively static and small.

@asapach commented on GitHub (Nov 5, 2019): > Should we ship a default blocklist ? Only if there is one which is relatively static and small.

kerem commented

2026-03-15 03:07:57 +03:00

Author

Owner

@Coriou commented on GitHub (Nov 5, 2019):

Thought about a way of doing this, and all are really bad:

Most blocklists don't come as a list of IPs, but usually as ranges so the users would first need to parse those lists into an array of unique IPs
The IPs would need to be loaded one by one, potentially loading millions of IPs for each torrent-stream engine

I think a better way would be to implement it at the torrent-stream level actually ... I've mentioned it there, let's see

@Coriou commented on GitHub (Nov 5, 2019): Thought about a way of doing this, and all are really bad: - Most blocklists don't come as a list of IPs, but usually as ranges so the users would first need to parse those lists into an array of unique IPs - The IPs would need to be loaded one by one, potentially loading millions of IPs for each torrent-stream engine I think a better way would be to implement it at the torrent-stream level actually ... I've mentioned it there, let's see