[GH-ISSUE #133] Use official node image in dockerfile #324

Closed
opened 2026-03-15 03:00:43 +03:00 by kerem · 2 comments
Owner

Originally created by @sgsunder on GitHub (Feb 15, 2018).
Original GitHub issue: https://github.com/asapach/peerflix-server/issues/133

Is there any reason why you're not using Docker's official node image in your dockerfile? i.e replacing FROM mhart/alpine-node:6 with FROM node:6-alpine.

The dockerfile builds and runs just as well with the change and I would assume that the official image is more secure.

Originally created by @sgsunder on GitHub (Feb 15, 2018). Original GitHub issue: https://github.com/asapach/peerflix-server/issues/133 Is there any reason why you're not using Docker's official node image in your dockerfile? i.e replacing `FROM mhart/alpine-node:6` with `FROM node:6-alpine`. The dockerfile builds and runs just as well with the change and I would assume that the official image is more secure.
kerem 2026-03-15 03:00:43 +03:00
Author
Owner

@sgsunder commented on GitHub (Feb 15, 2018):

Also, you can use apk --no-cache add instead of apk update && apk add ... && rm -fr /var/cache/apk. See this blog post

<!-- gh-comment-id:366029496 --> @sgsunder commented on GitHub (Feb 15, 2018): Also, you can use `apk --no-cache add` instead of `apk update && apk add ... && rm -fr /var/cache/apk`. See this [blog post](http://blog.zot24.com/tips-tricks-with-alpine-docker/)
Author
Owner

@asapach commented on GitHub (Feb 15, 2018):

A PR is welcome.

<!-- gh-comment-id:366034690 --> @asapach commented on GitHub (Feb 15, 2018): A PR is welcome.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/peerflix-server#324
No description provided.