mirror of
https://github.com/asapach/peerflix-server.git
synced 2026-04-25 14:45:50 +03:00
[GH-ISSUE #133] Use official node image in dockerfile #324
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sgsunder on GitHub (Feb 15, 2018).
Original GitHub issue: https://github.com/asapach/peerflix-server/issues/133
Is there any reason why you're not using Docker's official node image in your dockerfile? i.e replacing
FROM mhart/alpine-node:6withFROM node:6-alpine.The dockerfile builds and runs just as well with the change and I would assume that the official image is more secure.
@sgsunder commented on GitHub (Feb 15, 2018):
Also, you can use
apk --no-cache addinstead ofapk update && apk add ... && rm -fr /var/cache/apk. See this blog post@asapach commented on GitHub (Feb 15, 2018):
A PR is welcome.