[PR #123] [MERGED] Add ffmpeg into Dockerfile #175

New issue

Closed

opened 2026-02-25 20:32:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:32:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asapach/peerflix-server/pull/123
Author: @pryg-skok
Created: 9/14/2017
Status: ✅ Merged
Merged: 9/14/2017
Merged by: @asapach

Base: master ← Head: master

📝 Commits (1)

26f4428 Add ffmpeg into Dockerfile

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 Dockerfile (+1 -0)

📄 Description

A naive way - just to add ffmpeg into image is works. But it has some issues with calling code.

#122

The problem with function which calls ffmpeg:

    res.type('video/webm');
    var command = ffmpeg(file.createReadStream())
      .videoCodec('libvpx').audioCodec('libvorbis').format('webm')
      .audioBitrate(128)
      .videoBitrate(1024)
      .outputOptions([
        //'-threads 2',
        '-deadline realtime',
        '-error-resilient 1'
      ])

It's actually not only remuxing, but also transcoding audio and video with specified bitrates and only on single core which is likely can't be done in realtime even on high end systems without HW acceleration.

I'll open separate issue for this, and also proposes for different links for remuxed variants in #19 is pretty meaningful to implement.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asapach/peerflix-server/pull/123 **Author:** [@pryg-skok](https://github.com/pryg-skok) **Created:** 9/14/2017 **Status:** ✅ Merged **Merged:** 9/14/2017 **Merged by:** [@asapach](https://github.com/asapach) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`26f4428`](https://github.com/asapach/peerflix-server/commit/26f44287a7f2e341c209ca6b4fb83373015afeb6) Add ffmpeg into Dockerfile ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -0) </details> ### 📄 Description A naive way - just to add ffmpeg into image is works. But it has some issues with calling code. #122 The problem with function which calls ffmpeg: ``` function remux() { res.type('video/webm'); var command = ffmpeg(file.createReadStream()) .videoCodec('libvpx').audioCodec('libvorbis').format('webm') .audioBitrate(128) .videoBitrate(1024) .outputOptions([ //'-threads 2', '-deadline realtime', '-error-resilient 1' ]) ``` It's actually not only remuxing, but also transcoding audio and video with specified bitrates and only on single core which is likely can't be done in realtime even on high end systems without HW acceleration. I'll open separate issue for this, and also proposes for different links for remuxed variants in #19 is pretty meaningful to implement. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>