[GH-ISSUE #164] 2 mp4 file when download one completed,there is no obvious indication that one of them has been downloaded. #134

Open
opened 2026-02-25 20:32:31 +03:00 by kerem · 5 comments
Owner

Originally created by @JSZMonkey on GitHub (Jan 10, 2019).
Original GitHub issue: https://github.com/asapach/peerflix-server/issues/164

When a seed file contains 2 mp4 files, I only download one. When one of the downloads is completed, there is no obvious indication that one of them has been downloaded.

Originally created by @JSZMonkey on GitHub (Jan 10, 2019). Original GitHub issue: https://github.com/asapach/peerflix-server/issues/164 When a seed file contains 2 mp4 files, I only download one. When one of the downloads is completed, there is no obvious indication that one of them has been downloaded.
Author
Owner

@asapach commented on GitHub (Jan 10, 2019):

Yeah, the only indication is that the checkbox next to the file becomes unchecked. It's the consequence of using torrent-stream under the hood, because it doesn't provide any kind of api for this. I was thinking that instead of unchecking the checkbox I could try to make it checked and disabled, like this:
image
Thoughts?

<!-- gh-comment-id:453032947 --> @asapach commented on GitHub (Jan 10, 2019): Yeah, the only indication is that the checkbox next to the file becomes unchecked. It's the consequence of using [torrent-stream](https://github.com/mafintosh/torrent-stream) under the hood, because it doesn't provide any kind of api for this. I was thinking that instead of unchecking the checkbox I could try to make it checked and disabled, like this: ![image](https://user-images.githubusercontent.com/1755336/50959926-33bb1900-14d5-11e9-9bcb-f3ecd0f2bf35.png) Thoughts?
Author
Owner

@JSZMonkey commented on GitHub (Jan 10, 2019):

I think , don't add links without downloading and add Videos.mp4 tag, only have links to files when the file is downloaded and add .
And add a single file delete button, when I click the wrong download, I can delete this file.
And add the automatic transcoding function after the download is completed, and convert the video file format to mp4.

ps: like this

<!-- gh-comment-id:453064162 --> @JSZMonkey commented on GitHub (Jan 10, 2019): I think , don't add links without downloading and add <s>Videos.mp4</s> tag, only have links to files when the file is downloaded and add <img src=https://user-images.githubusercontent.com/1755336/50959926-33bb1900-14d5-11e9-9bcb-f3ecd0f2bf35.png>. And add a single file delete button, when I click the wrong download, I can delete this file. And add the automatic transcoding function after the download is completed, and convert the video file format to mp4. ps: like this <img src=https://raw.githubusercontent.com/JSZMonkey/Development/master/20190110201818.png> <img src=https://raw.githubusercontent.com/JSZMonkey/Development/master/20190110202306.png>
Author
Owner

@asapach commented on GitHub (Jan 10, 2019):

Sorry, but I disagree:

don't add links without downloading

The whole point of streaming torrents is that you don't need to download the whole file in order to access it. You can randomly seek inside the file that is partially downloaded.

add a single file delete button

Unfortunately files cannot be deleted once they are downloaded. You can only delete the entire torrent. That's how torrent clients are supposed to work, because they need to be able to seed the downloaded chunks.

add the automatic transcoding function

I've tried that a couple of years ago and it didn't work very reliably for real-time streaming, so I just gave up. I'm not planning to add any special handling for video files. I recommend using VLC to play the video files as network streams.

<!-- gh-comment-id:453159051 --> @asapach commented on GitHub (Jan 10, 2019): Sorry, but I disagree: > don't add links without downloading The whole point of *streaming* torrents is that you don't need to *download* the whole file in order to access it. You can randomly seek inside the file that is partially downloaded. > add a single file delete button Unfortunately files cannot be deleted once they are downloaded. You can only delete the entire torrent. That's how torrent clients are supposed to work, because they need to be able to seed the downloaded chunks. > add the automatic transcoding function I've tried that a couple of years ago and it didn't work very reliably for real-time streaming, so I just gave up. I'm not planning to add any special handling for video files. I recommend using VLC to play the video files as network streams.
Author
Owner

@nk932714 commented on GitHub (Jan 16, 2020):

@asapach can't we replace the tick mark with This type of downloading GIF ?
wip-bouncing-arrow-animation

and on downloading completion gif changes to this type of logo?
image

<!-- gh-comment-id:575035322 --> @nk932714 commented on GitHub (Jan 16, 2020): @asapach can't we replace the tick mark with This type of downloading GIF ? ![wip-bouncing-arrow-animation](https://user-images.githubusercontent.com/29853208/72505495-0df1ee00-3866-11ea-8bc3-12b5e2aafaa6.gif) and on downloading completion gif changes to this type of logo? ![image](https://user-images.githubusercontent.com/29853208/72505359-ca977f80-3865-11ea-9d2f-deda71ea7f7d.png)
Author
Owner

@asapach commented on GitHub (Jan 16, 2020):

@nk932714, the checkbox is meant to convey that the file is currently being downloaded (see here): if it's checked then somebody is interested in it (you can either check it manually, or it will activate automatically when streaming), otherwise it's idle. Replacing it with a gif won't make any functional difference and will only annoy people who hate animated gifs.
I'll think about what can be done better when the download completes.

<!-- gh-comment-id:575299883 --> @asapach commented on GitHub (Jan 16, 2020): @nk932714, the checkbox is meant to convey that the file is currently being downloaded (see [here](https://github.com/asapach/peerflix-server/blob/84447e850614a8e4694eed246a5e0f1ecbd26c9b/server/index.js#L49)): if it's checked then somebody is interested in it (you can either check it manually, or it will activate automatically when streaming), otherwise it's idle. Replacing it with a gif won't make any functional difference and will only annoy people who hate animated gifs. I'll think about what can be done better when the download completes.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/peerflix-server#134
No description provided.