[PR #216] [MERGED] Fix automates ACL and other #564

New issue

Closed

opened 2026-02-25 21:32:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:32:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ciur/papermerge/pull/216
Author: @francescocarzaniga
Created: 11/19/2020
Status: ✅ Merged
Merged: 11/20/2020
Merged by: @ciur

Base: master ← Head: automates_users

📝 Commits (6)

b74b9a7 Fix automates ACL
9546e9d Make destination folder optional
ded6754 Make destination folder optional
f2e4726 Merge branch 'automates_users' of github.com:francescocarzaniga/papermerge into automates_users
63dfe61 Fix migrations
be125bd Fix groups

📊 Changes

6 files changed (+50 additions, -11 deletions)

View changed files

📝 papermerge/contrib/admin/forms.py (+11 -2)
📝 papermerge/contrib/admin/templates/admin/automate.html (+2 -2)
📝 papermerge/contrib/admin/views/automates.py (+1 -1)
➕ papermerge/core/migrations/0033_auto_20201119_0032.py (+19 -0)
📝 papermerge/core/models/automate.py (+12 -4)
📝 papermerge/core/views/__init__.py (+5 -2)

📄 Description

Originally a simple fix to #202, I noticed a few problems with automates ACLs and changed those as well. This also fixes #185 since Inbox should never be selectable to avoid loops.
Made destination folder optional for #196. It is necessary to implement an ordering for automates to fully implement this FR, since right now if the first automate moves the document away from Inbox the others are never applied.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ciur/papermerge/pull/216 **Author:** [@francescocarzaniga](https://github.com/francescocarzaniga) **Created:** 11/19/2020 **Status:** ✅ Merged **Merged:** 11/20/2020 **Merged by:** [@ciur](https://github.com/ciur) **Base:** `master` ← **Head:** `automates_users` --- ### 📝 Commits (6) - [`b74b9a7`](https://github.com/ciur/papermerge/commit/b74b9a7584c27276ca58e67b95c4043bcbf7f372) Fix automates ACL - [`9546e9d`](https://github.com/ciur/papermerge/commit/9546e9df9c8c8fbf1d8ede97cc5ee4e06d6210ce) Make destination folder optional - [`ded6754`](https://github.com/ciur/papermerge/commit/ded675451d9b6b612f50268a79285603207c9b46) Make destination folder optional - [`f2e4726`](https://github.com/ciur/papermerge/commit/f2e47264531d0ae21f300bcf771727b719367051) Merge branch 'automates_users' of github.com:francescocarzaniga/papermerge into automates_users - [`63dfe61`](https://github.com/ciur/papermerge/commit/63dfe6192083d26873bb2d16e0f3027f442e5df1) Fix migrations - [`be125bd`](https://github.com/ciur/papermerge/commit/be125bdce21686a30d5595af9536e059cabe9a67) Fix groups ### 📊 Changes **6 files changed** (+50 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `papermerge/contrib/admin/forms.py` (+11 -2) 📝 `papermerge/contrib/admin/templates/admin/automate.html` (+2 -2) 📝 `papermerge/contrib/admin/views/automates.py` (+1 -1) ➕ `papermerge/core/migrations/0033_auto_20201119_0032.py` (+19 -0) 📝 `papermerge/core/models/automate.py` (+12 -4) 📝 `papermerge/core/views/__init__.py` (+5 -2) </details> ### 📄 Description Originally a simple fix to #202, I noticed a few problems with automates ACLs and changed those as well. This also fixes #185 since Inbox should never be selectable to avoid loops. Made destination folder optional for #196. It is necessary to implement an ordering for automates to fully implement this FR, since right now if the first automate moves the document away from Inbox the others are never applied. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>