[PR #375] [MERGED] fix: Input inserting KeyEvent with modifiers as text #492

New issue

Closed

opened 2026-03-02 23:46:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:46:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/375
Author: @kommander
Created: 12/2/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @kommander

Base: main ← Head: fix-pr-337

📝 Commits (4)

d56d9f5 fix: Input inserting KeyEvent with modifiers as text
89819eb check modifiers before insert for textarea as well
0405b55 super/hyper
17acaef adjust expectations

📊 Changes

8 files changed (+432 additions, -87 deletions)

View changed files

📝 packages/core/src/lib/parse.keypress.test.ts (+100 -49)
📝 packages/core/src/lib/parse.keypress.ts (+8 -4)
📝 packages/core/src/renderables/Input.ts (+3 -1)
📝 packages/core/src/renderables/Textarea.ts (+3 -1)
📝 packages/core/src/renderables/__tests__/Textarea.keybinding.test.ts (+133 -0)
📝 packages/core/src/testing/mock-keys.test.ts (+110 -0)
📝 packages/core/src/testing/mock-keys.ts (+47 -10)
📝 packages/core/src/tests/renderer.input.test.ts (+28 -22)

📄 Description

fixes the mess in #337

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/375 **Author:** [@kommander](https://github.com/kommander) **Created:** 12/2/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `fix-pr-337` --- ### 📝 Commits (4) - [`d56d9f5`](https://github.com/anomalyco/opentui/commit/d56d9f525cde4b71e539cff8ec7dca70180030b8) fix: Input inserting KeyEvent with modifiers as text - [`89819eb`](https://github.com/anomalyco/opentui/commit/89819ebaee07a76406a28f2d8e2c565bce60c69c) check modifiers before insert for textarea as well - [`0405b55`](https://github.com/anomalyco/opentui/commit/0405b55a587a3a28e831090044014488c1c6b45c) super/hyper - [`17acaef`](https://github.com/anomalyco/opentui/commit/17acaef9bdccbbd7f275c3183aae4e1256d145cc) adjust expectations ### 📊 Changes **8 files changed** (+432 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/lib/parse.keypress.test.ts` (+100 -49) 📝 `packages/core/src/lib/parse.keypress.ts` (+8 -4) 📝 `packages/core/src/renderables/Input.ts` (+3 -1) 📝 `packages/core/src/renderables/Textarea.ts` (+3 -1) 📝 `packages/core/src/renderables/__tests__/Textarea.keybinding.test.ts` (+133 -0) 📝 `packages/core/src/testing/mock-keys.test.ts` (+110 -0) 📝 `packages/core/src/testing/mock-keys.ts` (+47 -10) 📝 `packages/core/src/tests/renderer.input.test.ts` (+28 -22) </details> ### 📄 Description fixes the mess in #337 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>