[PR #492] [MERGED] [react] unmount when renderer is destroyed externally #1352

New issue

Closed

opened 2026-03-14 09:32:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:32:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/492
Author: @kommander
Created: 1/7/2026
Status: ✅ Merged
Merged: 1/7/2026
Merged by: @kommander

Base: main ← Head: destroy-race-repro

📝 Commits (4)

8473f28 test repro
038844b actual crash sequence
264aa40 fix(renderer): cleanup react on render destroy
bb82df4 maybe less flaky test

📊 Changes

3 files changed (+130 additions, -26 deletions)

View changed files

📝 packages/core/src/zig/tests/wrap-cache-perf_test.zig (+26 -15)
📝 packages/react/src/reconciler/renderer.ts (+13 -11)
➕ packages/react/tests/destroy-crash.test.tsx (+91 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/492 **Author:** [@kommander](https://github.com/kommander) **Created:** 1/7/2026 **Status:** ✅ Merged **Merged:** 1/7/2026 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `destroy-race-repro` --- ### 📝 Commits (4) - [`8473f28`](https://github.com/anomalyco/opentui/commit/8473f28dcf6ed1fc45bda2145a5cc08f0a5df70e) test repro - [`038844b`](https://github.com/anomalyco/opentui/commit/038844b7cafefbbad2a156aa199bb4d54e38ec24) actual crash sequence - [`264aa40`](https://github.com/anomalyco/opentui/commit/264aa40b8f5ea2c4bbecdeb59fe90936430060f3) fix(renderer): cleanup react on render destroy - [`bb82df4`](https://github.com/anomalyco/opentui/commit/bb82df4363b26d1f478993e2935f4641c81f07c2) maybe less flaky test ### 📊 Changes **3 files changed** (+130 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/zig/tests/wrap-cache-perf_test.zig` (+26 -15) 📝 `packages/react/src/reconciler/renderer.ts` (+13 -11) ➕ `packages/react/tests/destroy-crash.test.tsx` (+91 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>