[PR #180] [MERGED] Fix api calls #192

New issue

Closed

opened 2026-02-28 01:21:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:21:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tuxis-ie/nsedit/pull/180
Author: @tuxis-ie
Created: 8/22/2018
Status: ✅ Merged
Merged: 8/22/2018
Merged by: @tuxis-ie

Base: master ← Head: fix-api-calls

📝 Commits (2)

bf513b9 Assume that we have Pdns > 4.x
be647cc Do not insert 'localhost', we are autodetecting the API url

📊 Changes

2 files changed (+2 additions, -8 deletions)

View changed files

📝 includes/class/ApiHandler.php (+1 -7)
📝 includes/class/PdnsApi.php (+1 -1)

📄 Description

Fixes API calls to create zones. Also, ignore issues with versions and API. pdns < 4.0 is EOL and thus we assume a valid API-endpoint.

Tested with 4.0.3 and 4.1.3 and master.

Closes #178

Relates to #179 #162 #146

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tuxis-ie/nsedit/pull/180 **Author:** [@tuxis-ie](https://github.com/tuxis-ie) **Created:** 8/22/2018 **Status:** ✅ Merged **Merged:** 8/22/2018 **Merged by:** [@tuxis-ie](https://github.com/tuxis-ie) **Base:** `master` ← **Head:** `fix-api-calls` --- ### 📝 Commits (2) - [`bf513b9`](https://github.com/tuxis-ie/nsedit/commit/bf513b9ffda5849064ace9ec9034d6c99c6991f4) Assume that we have Pdns > 4.x - [`be647cc`](https://github.com/tuxis-ie/nsedit/commit/be647cc26a32a986917542ecb58867da8b6f7d37) Do not insert 'localhost', we are autodetecting the API url ### 📊 Changes **2 files changed** (+2 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `includes/class/ApiHandler.php` (+1 -7) 📝 `includes/class/PdnsApi.php` (+1 -1) </details> ### 📄 Description Fixes API calls to create zones. Also, ignore issues with versions and API. pdns < 4.0 is EOL and thus we assume a valid API-endpoint. Tested with 4.0.3 and 4.1.3 and master. Closes #178 Relates to #179 #162 #146 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>