[PR #137] Group support & permissions #180

New issue

Open

opened 2026-02-28 01:21:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:21:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tuxis-ie/nsedit/pull/137
Author: @richard-underwood
Created: 1/9/2017
Status: 🔄 Open

Base: master ← Head: issue-68

📝 Commits (10+)

a937d05 Missing variable in users.php
bc95d31 Merge remote-tracking branch 'origin/master' into issue-68
b0e012f Merge remote-tracking branch 'origin/issue-122' into issue-68
9b6ce20 Merge remote-tracking branch 'origin/master' into issue-68
e172ba6 Added group table to users tab. Allow group name editing for now.
1aa0f0b Added a check as jtable expects a list here.
417e9ca Basic group management support. Lots more to do.
d915137 Allow removal of members from groups.
c1598fc Fixed column widths
2b5e7ea Uncomitted changes prior to merge. Permissions ...

📊 Changes

14 files changed (+1450 additions, -242 deletions)

View changed files

➕ groups.php (+134 -0)
📝 includes/config.inc.php-dist (+6 -0)
➕ includes/database.inc.php (+60 -0)
➕ includes/groups.inc.php (+176 -0)
📝 includes/misc.inc.php (+94 -25)
➕ includes/permissions.inc.php (+253 -0)
📝 includes/scheme.sql (+36 -0)
➕ includes/upgrade-0-1.sql (+5 -0)
➕ includes/upgrade-1-2.sql (+29 -0)
📝 index.php (+454 -207)
📝 logs.php (+1 -1)
➕ permissions.php (+121 -0)
📝 users.php (+7 -1)
📝 zones.php (+74 -8)

📄 Description

Hi, this is a pretty big set of changes, so it would be worth getting some early feedback. It's designed to fix the following:

Issue 68 - group support
Issue 17 - forbid users from editing administrative records

Unfortunately, there's no point in having groups without some sort of permissions system, so that's included as well.

As the DB schema also needed updating for this, I've put a framework in place for schema versioning.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tuxis-ie/nsedit/pull/137 **Author:** [@richard-underwood](https://github.com/richard-underwood) **Created:** 1/9/2017 **Status:** 🔄 Open **Base:** `master` ← **Head:** `issue-68` --- ### 📝 Commits (10+) - [`a937d05`](https://github.com/tuxis-ie/nsedit/commit/a937d051635b6977569fe25408e7bf6f5c453814) Missing variable in users.php - [`bc95d31`](https://github.com/tuxis-ie/nsedit/commit/bc95d31121f198d08fb94296918e5adf184e73cf) Merge remote-tracking branch 'origin/master' into issue-68 - [`b0e012f`](https://github.com/tuxis-ie/nsedit/commit/b0e012fa54ddca518d0be4ce4a993468edb4f0d1) Merge remote-tracking branch 'origin/issue-122' into issue-68 - [`9b6ce20`](https://github.com/tuxis-ie/nsedit/commit/9b6ce2001e0922728e197f71e74fd47986b96334) Merge remote-tracking branch 'origin/master' into issue-68 - [`e172ba6`](https://github.com/tuxis-ie/nsedit/commit/e172ba6502053969d19f1f060463775b036f4d6b) Added group table to users tab. Allow group name editing for now. - [`1aa0f0b`](https://github.com/tuxis-ie/nsedit/commit/1aa0f0bbcaa795f7224990756d03756df8b875a0) Added a check as jtable expects a list here. - [`417e9ca`](https://github.com/tuxis-ie/nsedit/commit/417e9ca848e9fc6f213a33068ddb1d47a1934c57) Basic group management support. Lots more to do. - [`d915137`](https://github.com/tuxis-ie/nsedit/commit/d915137eff5bacdabafba50f14609489d3c9b64b) Allow removal of members from groups. - [`c1598fc`](https://github.com/tuxis-ie/nsedit/commit/c1598fc99ac432135b04594cfab42ba1e8103f99) Fixed column widths - [`2b5e7ea`](https://github.com/tuxis-ie/nsedit/commit/2b5e7ea5f64b08c7da646f9c9b1c0be02d023c97) Uncomitted changes prior to merge. Permissions ... ### 📊 Changes **14 files changed** (+1450 additions, -242 deletions) <details> <summary>View changed files</summary> ➕ `groups.php` (+134 -0) 📝 `includes/config.inc.php-dist` (+6 -0) ➕ `includes/database.inc.php` (+60 -0) ➕ `includes/groups.inc.php` (+176 -0) 📝 `includes/misc.inc.php` (+94 -25) ➕ `includes/permissions.inc.php` (+253 -0) 📝 `includes/scheme.sql` (+36 -0) ➕ `includes/upgrade-0-1.sql` (+5 -0) ➕ `includes/upgrade-1-2.sql` (+29 -0) 📝 `index.php` (+454 -207) 📝 `logs.php` (+1 -1) ➕ `permissions.php` (+121 -0) 📝 `users.php` (+7 -1) 📝 `zones.php` (+74 -8) </details> ### 📄 Description Hi, this is a pretty big set of changes, so it would be worth getting some early feedback. It's designed to fix the following: Issue 68 - group support Issue 17 - forbid users from editing administrative records Unfortunately, there's no point in having groups without some sort of permissions system, so that's included as well. As the DB schema also needed updating for this, I've put a framework in place for schema versioning. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>