[GH-ISSUE #3] English README? #3

Closed
opened 2026-03-04 12:17:51 +03:00 by kerem · 5 comments
Owner

Originally created by @dvershinin on GitHub (Aug 23, 2020).
Original GitHub issue: https://github.com/ADD-SP/ngx_waf/issues/3

Originally created by @dvershinin on GitHub (Aug 23, 2020). Original GitHub issue: https://github.com/ADD-SP/ngx_waf/issues/3
kerem 2026-03-04 12:17:51 +03:00
Author
Owner

@ADD-SP commented on GitHub (Aug 23, 2020):

README-EN.md

Hello, thanks for your attention to this project. Please click the link above to view the English document. If there is some content that cannot be understood, please point it out so that I can correct it, and you can create a Pull Request to help correct it if you want.

<!-- gh-comment-id:678791474 --> @ADD-SP commented on GitHub (Aug 23, 2020): [README-EN.md](https://github.com/ADD-SP/ngx_waf/blob/dev/README-EN.md) Hello, thanks for your attention to this project. Please click the link above to view the English document. If there is some content that cannot be understood, please point it out so that I can correct it, and you can create a Pull Request to help correct it if you want.
Author
Owner

@ADD-SP commented on GitHub (Sep 1, 2020):

Hello, thank you for your help in this project. This module will release v2.0 within one month and close this issue at the same time. If you think it should not be closed, you can reopen it. Of course, if you think this issue has been resolved, you can also close it yourself.

v2.0.0-beta.1

<!-- gh-comment-id:684939850 --> @ADD-SP commented on GitHub (Sep 1, 2020): Hello, thank you for your help in this project. This module will release v2.0 within one month and close this issue at the same time. If you think it should not be closed, you can reopen it. Of course, if you think this issue has been resolved, you can also close it yourself. [v2.0.0-beta.1](https://github.com/ADD-SP/ngx_waf/releases/tag/v2.0.0-beta.1)
Author
Owner

@dvershinin commented on GitHub (Sep 6, 2020):

Please see #5.

On another note, I think README.md and CHANGES.md should be the English version and something like README-ZH.md for Chinese version. (just opinionated, to get some traction for the module, because most users would be probably non-Chinese speaking as myself).

<!-- gh-comment-id:687720321 --> @dvershinin commented on GitHub (Sep 6, 2020): Please see #5. On another note, I think `README.md` and `CHANGES.md` should be the English version and something like `README-ZH.md` for Chinese version. (just opinionated, to get some traction for the module, because most users would be probably non-Chinese speaking as myself).
Author
Owner

@ADD-SP commented on GitHub (Sep 6, 2020):

Please see aa861da.

I think what you said makes sense, so I made the following changes:

  • Rename README-EN.md to README.md
  • Rename CHANGES-EN.md to CHANGES.md
  • Rename the old README.md to README-ZH.md
  • Rename the old CHANGES.md to CHANGES-ZH.md
<!-- gh-comment-id:687781459 --> @ADD-SP commented on GitHub (Sep 6, 2020): Please see aa861da. I think what you said makes sense, so I made the following changes: * Rename `README-EN.md` to `README.md` * Rename `CHANGES-EN.md` to `CHANGES.md` * Rename the old `README.md` to `README-ZH.md` * Rename the old `CHANGES.md` to `CHANGES-ZH.md`
Author
Owner

@ADD-SP commented on GitHub (Sep 29, 2020):

Thank you for your interest in the project, I have closed the issue since v2.0.0 has been released. If you still have problems you can reopen it.

<!-- gh-comment-id:700490474 --> @ADD-SP commented on GitHub (Sep 29, 2020): Thank you for your interest in the project, I have closed the issue since [v2.0.0](https://github.com/ADD-SP/ngx_waf/releases/tag/v2.0.0) has been released. If you still have problems you can reopen it.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ngx_waf#3
No description provided.