[PR #407] [CLOSED] Always load access list details for proxy hosts #3242

New issue

Closed

opened 2026-02-26 07:38:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/407
Author: @Indemnity83
Created: 5/11/2020
Status: ❌ Closed

Base: develop ← Head: query-builder

📝 Commits (1)

c895a85 always load access list details for proxy host

📊 Changes

4 files changed (+29 additions, -13 deletions)

View changed files

📝 backend/internal/access-list.js (+4 -3)
📝 backend/internal/proxy-host.js (+4 -5)
📝 backend/models/proxy_host.js (+10 -5)
➕ backend/query/proxy_host.js (+11 -0)

📄 Description

This PR extracts a decorated QueryBuilder for the proxy_host model which will always load the access list and its details any time the proxy_host model is hydrated.

This PR potentially fixes a slew of "internal error" bugs where access list details were not available when attempting to construct the Nginx config file for proxy hosts.

Fixes #382 by populating the access list details when adding a certificate to a proxy host

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/407 **Author:** [@Indemnity83](https://github.com/Indemnity83) **Created:** 5/11/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `query-builder` --- ### 📝 Commits (1) - [`c895a85`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c895a852fb5411142a3e636ecb71e1141296c582) always load access list details for proxy host ### 📊 Changes **4 files changed** (+29 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/access-list.js` (+4 -3) 📝 `backend/internal/proxy-host.js` (+4 -5) 📝 `backend/models/proxy_host.js` (+10 -5) ➕ `backend/query/proxy_host.js` (+11 -0) </details> ### 📄 Description This PR extracts a decorated QueryBuilder for the proxy_host model which will always load the access list and its details any time the proxy_host model is hydrated. This PR potentially fixes a slew of "internal error" bugs where access list details were not available when attempting to construct the Nginx config file for proxy hosts. Fixes #382 by populating the access list details when adding a certificate to a proxy host --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:35 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3242

No description provided.

Rows
Columns