mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 09:25:55 +03:00
[GH-ISSUE #1717] SSL issue / port appended after upgrade to 2.9.14 #1276
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#1276
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pseudomix on GitHub (Jan 2, 2022).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/1717
Hello incredible NPM Team !
Checklist
jc21/nginx-proxy-manager:latestdocker image?Describe the bug
After the update to 2.9.14 some proxy hosts are not working any more.
It seems that NPM doesn't do correctly the reverse proxy as i see in the browser address that he tries to access the internal port.
Reverting to the previous release fix the issue.
Nginx Proxy Manager Version
2.9.14
To Reproduce
Steps to reproduce the behavior:
Browser reports bad SSL (SSL_ERROR_RX_RECORD_TOO_LONG) or in the best case the page appears but without any CSS Style
FYI: My NPM is behind Cloudflare DNS
Expected behavior
Site should appear correctly like before
Operating System
Docker Image on Debian 11.2
Reverting to 2.9.13 solves the issue. I'm not an expert with nginx.
Tried to recreate a simple Proxy-Host from scratch but same issue.
Hope this will help someone.
Thanks in advance for your help
@pseudomix commented on GitHub (Jan 3, 2022):
Hello,
I'm still able to login into my NPM interface and i can't see any error on my Container Log nor Nginx logs.
I think it's not the same issue as @ch4ox mentionned but maybe i'm wrong.
Thanks for your help
@chaptergy commented on GitHub (Jan 4, 2022):
Have you tried disabling Cloudflare to check whether this only happens in conjunction with cloudflare or with just npm as well?
@vilvic commented on GitHub (Jan 4, 2022):
We're seeing the same issue and have had to rollback to a previous version. Redirects seem to pick up the internal port
@Nesci28 commented on GitHub (Jan 4, 2022):
Same problem is happening here. Had to rollback to 2.9.13.
@PaPaTheGMan commented on GitHub (Jan 4, 2022):
Same problem, rollback to 2.9.13 fixes issue.
@pseudomix commented on GitHub (Jan 4, 2022):
Hello,
@chaptergy : i have tried to diable Cloudflare Proxying and still the same.
To illustrate @vilvic in my case i access https://someapp.mydom.com and i'm automticaly redirected to https://someapp.mydom.com:12784 where 12784 is the internal port of a docker containers exposed to my Lan.
As it does not do this issue with most of my apps i have checked if it's related to the App Behind (linuxserver/heimdall).
I have tried to pull an older version but same issue.
I have tried with a fresh image out of the box but same issue too.
Can somenone tell me what logs or file to check to help solve this issue?
Thanks for your help.
@Killator commented on GitHub (Jan 4, 2022):
Hello,
Same issue for me... Context:
"Classic DNS" > Home router > rPI 4 (Debian Bulleyes up-to-date) > NPM (HTTP/80&443) > Heimdall (HTTP/82 - docker - network conf. bridge).
Update on 2.9.14 > Page KO
Rollback on 2.9.13 > Page OK
Quick investigation on 2.9.14:
Don't hesitate to mention me if you need more info ! :-)
@chaptergy commented on GitHub (Jan 4, 2022):
Unfortunately I'm currently not able to replicate the issue on my dev instance, but based on the number of thumbs this seems to be a widespread issue. (Btw, very good etiquette of using the reactions instead of commenting without additional useful information, thanks!)
One of the things changed with nginx configs is the addition of the
X-Forwarded-HostandX-Forwarded-Portheaders. But I can't really explain how they cause this. I have found that setting theHostheader to the domain with an IP causes a redirect to there, but I'm not yet seeing why the host header would be changed. Maybe the applications you are proxying use this newX-Forwarded-...header and somehow mix this information?@pseudomix @Killator Would one of you guys be able to edit the nginx config manually (located at
/data/nginx/proxy_host/<id>.conf, where<id>is the actual id of the host) and remove these two lines everywhere they are used, to see if they are actually connected to the issue?@purcilas commented on GitHub (Jan 5, 2022):
I tried rolling back to the 2.9.13 docker image but still broken. Any additional steps I need to take?
@pseudomix commented on GitHub (Jan 5, 2022):
Hi @chaptergy ,
I checked my host config file but not found any occurrence of the related lines sorry.
@Killator commented on GitHub (Jan 6, 2022):
Hi @chaptergy,
I confirm, there is no
proxy_set_headerin my config file either...conf.d/include/proxy.conf > Seem to be inside the container
/data/nginx/custom/server_proxy[.]conf > The
customdirectory don't exist innginx... (same thing with 'find' command on *.conf)@virse commented on GitHub (Jan 6, 2022):
I can confirm pseudomix,
the mentioned related lines are also not in my config.
greets
@chaptergy commented on GitHub (Jan 6, 2022):
Yeah sorry, the directive is only included instead of explicitly generated in the file, so you would have to edit the
conf.d/include/proxy.conffile and remove the directives from there@pseudomix commented on GitHub (Jan 6, 2022):
Hi Chaptergy,
This did the trick!
Removing:
from /etc/nginx/conf.d/include/proxy.conf worked for me.
In the meantime i have mount this file outside of the image to don't loose the change in case of recreating the container.
Feel free to ask me other test.
Thanks
@filerun commented on GitHub (Jan 7, 2022):
Looks like
$portget's replaced with the proxied host's port (the local port) instead of the port number used in the browser (the external port).@poltrian commented on GitHub (Jan 10, 2022):
I have redirect to port 80 since the last update on Pixelfed
@atbakken commented on GitHub (Jan 11, 2022):
Sorry for my ignorance as I'm not 100% familiar with nginx reverse proxy, but why would the following be used:
proxy_set_header X-Forwarded-Port $port;in favour of using the following:
proxy_set_header X-Forwarded-Port $server_port;Would we not want to use server_port as it's the original requested port?
@jc21 commented on GitHub (Jan 11, 2022):
Please try the
jc21/nginx-proxy-manager:github-developdocker image, which has these headers removed and comment whether this is problem is fixed.@pseudomix commented on GitHub (Jan 11, 2022):
Hello jc21,
Problem fixed with this develop version.
Thanks for your investigations and thanks for this awesome developement.
@poltrian commented on GitHub (Jan 11, 2022):
I had problems with the login on Pixelfed- It was always forwarded to port 80. With the developer version it works correctly again
@Killator commented on GitHub (Jan 11, 2022):
Working fine ! Thanks a lot ! 👍
@silent001 commented on GitHub (Jan 14, 2022):
I can confirm that I am having the same issue with 2.9.14. If I inspect my site (laravel site) then the server port is appended to the end of the url. This was not an issue before and I don't know how to go back to a previous version. I have pulled and used the latest
jc21/nginx-proxy-manager:github-developimage and this has fixed the issue for me as well. I just pulled the latest today and noticed this issue. What is the correct course of action for people with this issue?@AlthaTechnology commented on GitHub (Jan 18, 2022):
On this it did break one of my apps. Invoice Ninja, running in docker swarm. To fix that I changed my internal apache port on that application to 443 and that fixed it, but this thread answers why I was seeing the :80 at the end of the URL.
I will add that it fixed a long standing issue I've been having with an AVideo site. When going from the main site, to the encoder site, it would delay sometimes up to 2 minutes. The usernames/credentials get passed in that transition, these additions fixed that transition.
I can add these headers onto specific proxy hosts through the custom config in the UI? Is that right?
And if anyone has any follow up information to @atbakken 's comment concerning the different way to implement a similar header that might shed some light on this for my use case. This would be great to have by default as it does seem to be an improvement.
And thanks for this project! I'm using it extensively for 100+ websites/applications in front of a multiple node docker swarm configuration.
Sincerely,
Jared
@jiangge commented on GitHub (Mar 24, 2022):
Hello jc21,
It's not been fixed yet, the docker-compose.yml is as follows:
@speculaas19 commented on GitHub (Mar 31, 2023):
image: 'jc21/nginx-proxy-manager:github-develop' dit the trick for me.