mirror of
https://github.com/hirschmann/nbfc.git
synced 2026-04-26 17:15:58 +03:00
[PR #1004] [CLOSED] Add newer Intel CPUs from openhardwaremonitor-0.9.5 #1390
Labels
No labels
Stale
bug
config
discussion
duplicate
enhancement
experimental
feature
help-wanted
info
invalid
invalid
pull-request
question
up-for-grabs
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nbfc-hirschmann#1390
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hirschmann/nbfc/pull/1004
Author: @Dwedit
Created: 10/12/2020
Status: ❌ Closed
Base:
master← Head:master📝 Commits (1)
e60187fCopy-paste newer CPUs from the newer version of openhardwaremonitor-0.9.5📊 Changes
1 file changed (+60 additions, -22 deletions)
View changed files
📝
Core/Plugins/OpenHardwareMonitor/Hardware/CPU/IntelCPU.cs(+60 -22)📄 Description
To fix issue #1003 and add support for newer CPUs released after 2017.
The service was throwing an exception on startup, and this led to the program not working, and creating over 4000 startup failures in the event log.
The cause was that it was unable to find the CPU sensors. Upgrading the Intel CPU code to a newer version of openhardwaremonitor-0.9.5 seems to have fixed the problem.
Note that this is a hack-job of selectively copy-pasting lines from openhardwaremonitor-0.9.5 in a way to not break compatibility, the code no longer matches any released version. Ideally, we'd want to upgrade all the code to openhardwaremonitor-0.9.5, but some code that uses it currently doesn't work with that version.
Perhaps we'd also like to have the service no longer set to endlessly restart itself on every failure.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.