[PR #697] [MERGED] Cosmetic update for config of Gigabyte AERO 14KV8 #1339

New issue

Closed

opened 2026-02-26 00:35:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 00:35:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hirschmann/nbfc/pull/697
Author: @christiansteinert
Created: 5/28/2019
Status: ✅ Merged
Merged: 6/5/2019
Merged by: @hirschmann

Base: master ← Head: christiansteinert-patch-2

📝 Commits (1)

31327ad Cosmetic update for config of Gigabyte AERO 14KV8

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 Configs/Gigabyte AERO 14KV8.xml (+6 -6)

📄 Description

Thank you for the quick merge and the kind words.

This is a small cosmetic update for the Gigabyte AERO 14KV8 configuration that you just pulled:

one of the RegisterWriteConfigurations unnecessarily had the write mode set to "OnWriteFanSpeed" even though it is enough to set the respective register once in order to enable the required fan mode. This is now fixed by setting the write mode to "OnInitialization" so that the register is not written all the time without need for it.
for one of the fans the temperature ranges were not listed in ascending order. This is not actually a problem but ascending order is nicer to read so I fixed this as well :-)

Thanks again for your great work and sorry for not catching these things right away
Christian

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hirschmann/nbfc/pull/697 **Author:** [@christiansteinert](https://github.com/christiansteinert) **Created:** 5/28/2019 **Status:** ✅ Merged **Merged:** 6/5/2019 **Merged by:** [@hirschmann](https://github.com/hirschmann) **Base:** `master` ← **Head:** `christiansteinert-patch-2` --- ### 📝 Commits (1) - [`31327ad`](https://github.com/hirschmann/nbfc/commit/31327adad047ba0b935d23c6a852ccd2a6ba491e) Cosmetic update for config of Gigabyte AERO 14KV8 ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Configs/Gigabyte AERO 14KV8.xml` (+6 -6) </details> ### 📄 Description Thank you for the quick merge and the kind words. This is a small cosmetic update for the Gigabyte AERO 14KV8 configuration that you just pulled: - one of the RegisterWriteConfigurations unnecessarily had the write mode set to "OnWriteFanSpeed" even though it is enough to set the respective register once in order to enable the required fan mode. This is now fixed by setting the write mode to "OnInitialization" so that the register is not written all the time without need for it. - for one of the fans the temperature ranges were not listed in ascending order. This is not actually a problem but ascending order is nicer to read so I fixed this as well :-) Thanks again for your great work and sorry for not catching these things right away Christian --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>