mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 08:05:53 +03:00
[PR #58] [MERGED] Added a ChromePhpHandler. #906
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#906
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Seldaek/monolog/pull/58
Author: @stof
Created: 2/19/2012
Status: ✅ Merged
Merged: 2/20/2012
Merged by: @Seldaek
Base:
master← Head:chromephp📝 Commits (2)
e3e2bb2Added a ChromePhpHandler.68702d3Detect Chrome through the user agent in ChromePhpHandler📊 Changes
7 files changed (+466 additions, -1 deletions)
View changed files
📝
CHANGELOG.mdown(+1 -0)📝
README.mdown(+2 -0)➕
src/Monolog/Formatter/ChromePhpFormatter.php(+77 -0)➕
src/Monolog/Handler/ChromePhpHandler.php(+127 -0)➕
tests/Monolog/Formatter/ChromePhpFormatterTest.php(+158 -0)📝
tests/Monolog/Functional/Handler/FirePHPHandlerTest.php(+3 -1)➕
tests/Monolog/Handler/ChromePhpHandlerTest.php(+98 -0)📄 Description
Closes #56
Currently, the handling of the context is done in the same way than for FirePHP: sending an array containing the message, the context and the extras.
The header is used for all browser so it will face the same issue in IE than the original FirePHPHandler implementation. But I haven't seen a way to determine if the extension is activated or no when looking at the request header. It would probably require some changes in the ChromePHP side to add a request header. @ccampbell do you think it could be possible ?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.