[GH-ISSUE #170] FingersCrossedHandler does not use registered processors #56

Closed
opened 2026-03-04 02:11:44 +03:00 by kerem · 2 comments
Owner

Originally created by @tpetry on GitHub (Mar 11, 2013).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/170

Processors registered to FingersCrossedHandler will not be included in any logged information because FingersCrossedHandler extends AbstractHandler and not AbstractProcessingHandler.

But it's nowhere documented (not in documentation nor in the sourcecode) that FingersCrossedHandler will not run the log message through registered processors. They are added and silently ignored. I don't know whether it's expected behaviour (then adding an processor should throw an exception) or simply an bug.

Originally created by @tpetry on GitHub (Mar 11, 2013). Original GitHub issue: https://github.com/Seldaek/monolog/issues/170 Processors registered to FingersCrossedHandler will not be included in any logged information because FingersCrossedHandler extends AbstractHandler and not AbstractProcessingHandler. But it's nowhere documented (not in documentation nor in the sourcecode) that FingersCrossedHandler will not run the log message through registered processors. They are added and silently ignored. I don't know whether it's expected behaviour (then adding an processor should throw an exception) or simply an bug.
kerem closed this issue 2026-03-04 02:11:45 +03:00
Author
Owner

@stof commented on GitHub (Mar 11, 2013):

the same is true for all other handlers forwarding to record to a nested handler.

<!-- gh-comment-id:14726357 --> @stof commented on GitHub (Mar 11, 2013): the same is true for all other handlers forwarding to record to a nested handler.
Author
Owner

@Seldaek commented on GitHub (Mar 11, 2013):

Indeed BufferHandler, FingersCrossedHandler, GroupHandler and NullHandler are affected. The latter is not an issue really. The others should be fixed. One note though, in the case of the FingersCrossedHandler you really should put the processors after it to avoid wasting cycles on processing log records that will never be stored, but that's a detail.

<!-- gh-comment-id:14744388 --> @Seldaek commented on GitHub (Mar 11, 2013): Indeed BufferHandler, FingersCrossedHandler, GroupHandler and NullHandler are affected. The latter is not an issue really. The others should be fixed. One note though, in the case of the FingersCrossedHandler you really should put the processors _after_ it to avoid wasting cycles on processing log records that will never be stored, but that's a detail.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/monolog#56
No description provided.