[GH-ISSUE #1788] LogRecord->with does not transfers "formatted" value #757

New issue

Open

opened 2026-03-04 02:17:43 +03:00 by kerem · 4 comments

kerem commented

2026-03-04 02:17:43 +03:00

Owner

Originally created by @Justinas-Jurciukonis on GitHub (Jan 17, 2023).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1788

Monolog version 3.2.0

When PsrLogMessageProcessor processes message, it returns new instance of LogRecord using code

return $record->with(message: strtr($record->message, $replacements), context: $context);

and inside LogRecord->with there is missing formatted key to be copied over, so if any previous processor set any information inside LogRecord->formatted it will be lost.

Seems like same issue with toArray

Originally created by @Justinas-Jurciukonis on GitHub (Jan 17, 2023). Original GitHub issue: https://github.com/Seldaek/monolog/issues/1788 Monolog version 3.2.0 When `PsrLogMessageProcessor` processes message, it returns new instance of `LogRecord` using code ```php return $record->with(message: strtr($record->message, $replacements), context: $context); ``` and inside [`LogRecord->with`](https://github.com/Seldaek/monolog/blob/main/src/Monolog/LogRecord.php#L118) there is missing `formatted` key to be copied over, so if any previous processor set any information inside `LogRecord->formatted` it will be lost. Seems like same issue with `toArray`

kerem added the

Bug

label

2026-03-04 02:17:43 +03:00

kerem commented

2026-03-04 02:17:43 +03:00

Author

Owner

@Seldaek commented on GitHub (Feb 4, 2023):

Normally formatting happens after processing, so this should never be a problem. Have you experienced an actual issue?

@Seldaek commented on GitHub (Feb 4, 2023): Normally formatting happens after processing, so this should never be a problem. Have you experienced an actual issue?

kerem commented

2026-03-04 02:17:43 +03:00

Author

Owner

@Justinas-Jurciukonis commented on GitHub (Feb 6, 2023):

@Seldaek Yes, since we use custom logic to format all records.

Basically logic was as follows:

Create new structure to formatted property
Every processor adds it's own information to this formatted to the place where it needs to be
Formatter converts log record to JSON or Plain text log, but keeps structure from formatted. Means formatters only responsible for final output, but not structure of log itself

With this approach formatters does not care about structure, just how format LogRecord to string. Processors are responsible for it's own parts of LogRecord->formatted processing.

E.g. Adding information about current user can come from 3 different processors and it merges under key LogRecord->formatted->user

@Justinas-Jurciukonis commented on GitHub (Feb 6, 2023): @Seldaek Yes, since we use custom logic to format all records. Basically logic was as follows: 1. Create new structure to `formatted` property 2. Every processor adds it's own information to this `formatted` to the place where it needs to be 3. Formatter converts log record to JSON or Plain text log, but keeps structure from `formatted`. Means formatters only responsible for final output, but not structure of log itself With this approach formatters does not care about structure, just how format `LogRecord` to string. Processors are responsible for it's own parts of `LogRecord->formatted` processing. E.g. Adding information about current user can come from 3 different processors and it merges under key `LogRecord->formatted->user`

kerem commented

2026-03-04 02:17:44 +03:00

Author

Owner

@stof commented on GitHub (Feb 6, 2023):

This looks like the use case for LogRecord->extra instead

@stof commented on GitHub (Feb 6, 2023): This looks like the use case for `LogRecord->extra` instead

kerem commented

2026-03-04 02:17:44 +03:00

Author

Owner

@Seldaek commented on GitHub (Feb 7, 2023):

Right, exactly my thinking @stof - sounds to me like these processors should all record stuff in extra as they are meant to, and then the final formatter can use the info in context/extra to generate the final formatted record.

@Seldaek commented on GitHub (Feb 7, 2023): Right, exactly my thinking @stof - sounds to me like these processors should all record stuff in extra as they are meant to, and then the final formatter can use the info in context/extra to generate the final formatted record.

kerem referenced this issue

2026-03-04 03:09:52 +03:00

[PR #757] [MERGED] missing property #1333