[PR #757] [MERGED] missing property #1333

New issue

Closed

opened 2026-03-04 03:09:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:09:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/757
Author: @remicollet
Created: 3/25/2016
Status: ✅ Merged
Merged: 3/25/2016
Merged by: @Seldaek

Base: 1.x ← Head: issue-ver

📝 Commits (1)

8cfc819 missing property

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/Monolog/Handler/SocketHandler.php (+1 -0)

📄 Description

This property is used, but not declared, in writingIsTimedOut

Don't know why it pass on travis, but locally I got

Monolog\Handler\SocketHandlerTest::testAvoidInfiniteLoopWhenNoDataIsWrittenForAWritingTimeoutSeconds
Undefined property: Mock_SocketHandler_4c030aea::$lastWritingAt

This trivial fix fix this

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/757 **Author:** [@remicollet](https://github.com/remicollet) **Created:** 3/25/2016 **Status:** ✅ Merged **Merged:** 3/25/2016 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `1.x` ← **Head:** `issue-ver` --- ### 📝 Commits (1) - [`8cfc819`](https://github.com/Seldaek/monolog/commit/8cfc819265183c57e5b24528d766768f55ae76df) missing property ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Handler/SocketHandler.php` (+1 -0) </details> ### 📄 Description This property is used, but not declared, in writingIsTimedOut Don't know why it pass on travis, but locally I got 1) Monolog\Handler\SocketHandlerTest::testAvoidInfiniteLoopWhenNoDataIsWrittenForAWritingTimeoutSeconds Undefined property: Mock_SocketHandler_4c030aea::$lastWritingAt This trivial fix fix this --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>