mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-27 00:25:50 +03:00
[GH-ISSUE #1054] StreamHandler: Set $useLocking to true by default #428
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#428
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomsommer on GitHub (Sep 13, 2017).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1054
Would it not make sense to set $useLocking to true by default? Otherwise you risk random concurrency/permission errors.
github.com/Seldaek/monolog@7405bb5d67/src/Monolog/Handler/StreamHandler.php (L39)github.com/Seldaek/monolog@07b6c1c417/src/Monolog/Handler/RotatingFileHandler.php (L45)@Seldaek commented on GitHub (Jun 17, 2018):
As per https://github.com/Seldaek/monolog/issues/379 - this is only an issue if you log long lines or in very odd setups. For most use cases locking isn't needed even with high concurrency, so I don't think it's a good idea to enable by default.