[PR #428] [MERGED] NewRelicHandler: Prevent newrelic_add_custom_parameter() overwriting #1145

New issue

Closed

opened 2026-03-04 03:05:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:05:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/428
Author: @moderndeveloperllc
Created: 9/29/2014
Status: ✅ Merged
Merged: 9/29/2014
Merged by: @Seldaek

Base: master ← Head: master

📝 Commits (1)

e7647fd Add prefixes to the context and extra record keys. Needed as some processors have the same keys as the the context. Specifically, the IntrospectionProcessor has "line" and "file" that can overwrite an error context "line" and "file".

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 src/Monolog/Handler/NewRelicHandler.php (+2 -2)
📝 tests/Monolog/Handler/NewRelicHandlerTest.php (+4 -4)

📄 Description

Add prefixes to the context and extra record keys. Needed as some processors have the same keys as the the context. Specifically, the IntrospectionProcessor has "line" and "file" that can overwrite an error context "line" and "file". If there is something like an E_PARSE error, the context variables are set, but the IntrospectionProcessor gets nulls. Tested on Lite account (screenshot below)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/428 **Author:** [@moderndeveloperllc](https://github.com/moderndeveloperllc) **Created:** 9/29/2014 **Status:** ✅ Merged **Merged:** 9/29/2014 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e7647fd`](https://github.com/Seldaek/monolog/commit/e7647fd37d248c7ef704616b53c5b6757105db1a) Add prefixes to the context and extra record keys. Needed as some processors have the same keys as the the context. Specifically, the IntrospectionProcessor has "line" and "file" that can overwrite an error context "line" and "file". ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Handler/NewRelicHandler.php` (+2 -2) 📝 `tests/Monolog/Handler/NewRelicHandlerTest.php` (+4 -4) </details> ### 📄 Description Add prefixes to the context and extra record keys. Needed as some processors have the same keys as the the context. Specifically, the `IntrospectionProcessor` has "line" and "file" that can overwrite an error context "line" and "file". If there is something like an E_PARSE error, the context variables are set, but the `IntrospectionProcessor` gets nulls. Tested on Lite account (screenshot below) ![newrelic](https://cloud.githubusercontent.com/assets/1920405/4444811/b9921802-47f3-11e4-88d7-9421ba7c7e35.jpg) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>