[PR #1381] [MERGED] fix: do not save the domain if not necessary. #2215

Closed
opened 2026-02-27 12:09:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1381
Author: @tonioo
Created: 1/31/2018
Status: Merged
Merged: 1/31/2018
Merged by: @tonioo

Base: masterHead: fix/avoid_useless_save


📝 Commits (1)

  • 5164ecd fix: do not save the domain if not necessary.

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 modoboa/relaydomains/forms.py (+3 -2)

📄 Description

it will also avoid the trigger of two post_save signals for the domain,
which can lead to unexpected issues.

see #1380


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1381 **Author:** [@tonioo](https://github.com/tonioo) **Created:** 1/31/2018 **Status:** ✅ Merged **Merged:** 1/31/2018 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `fix/avoid_useless_save` --- ### 📝 Commits (1) - [`5164ecd`](https://github.com/modoboa/modoboa/commit/5164ecdfdf70815177d5f4eb57454bd0132a085b) fix: do not save the domain if not necessary. ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/relaydomains/forms.py` (+3 -2) </details> ### 📄 Description it will also avoid the trigger of two post_save signals for the domain, which can lead to unexpected issues. see #1380 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 12:09:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/modoboa-modoboa#2215
No description provided.