mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-26 17:36:01 +03:00
[GH-ISSUE #1664] Traceback: check_mx #1306
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1306
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cremesk on GitHub (Feb 2, 2019).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/1664
Impacted versions
Steps to reproduce
/srv/modoboa/env/bin/python /srv/modoboa/instance/manage.py modo check_mx
Traceback (most recent call last):
File "/srv/modoboa/instance/manage.py", line 22, in
execute_from_command_line(sys.argv)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/django/core/management/init.py", line 364, in execute_from_command_line
utility.execute()
File "/srv/modoboa/env/local/lib/python2.7/site-packages/django/core/management/init.py", line 356, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/subcommand/base.py", line 53, in run_from_argv
return super(SubcommandCommand, self).run_from_argv(argv)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/django/core/management/base.py", line 283, in run_from_argv
self.execute(*args, **cmd_options)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/django/core/management/base.py", line 330, in execute
output = self.handle(*args, **options)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/subcommand/base.py", line 84, in handle
return command.run_from_argv(argv)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/django/core/management/base.py", line 283, in run_from_argv
self.execute(*args, **cmd_options)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/django/core/management/base.py", line 330, in execute
output = self.handle(*args, **options)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/modoboa/admin/management/commands/subcommands/_mx.py", line 264, in handle
self.check_domain(domain, **options)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/modoboa/admin/management/commands/subcommands/_mx.py", line 195, in check_domain
self.check_valid_mx(domain, mx_list, **options)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/modoboa/admin/management/commands/subcommands/_mx.py", line 154, in check_valid_mx
valid_mxs = self.valid_mxs
File "/srv/modoboa/env/local/lib/python2.7/site-packages/django/utils/functional.py", line 35, in get
res = instance.dict[self.name] = self.func(instance)
File "/srv/modoboa/env/local/lib/python2.7/site-packages/modoboa/admin/management/commands/subcommands/_mx.py", line 48, in valid_mxs
for v in valid_mxs.split() if v.strip()]
File "/srv/modoboa/env/local/lib/python2.7/site-packages/ipaddress.py", line 204, in ip_network
address)
ValueError: u'mail.secnux.net' does not appear to be an IPv4 or IPv6 network
@tonioo commented on GitHub (Feb 3, 2019):
@cremesk The "valid mxs" option should only contain ip addresses, not domain names.
@tuxis-ie commented on GitHub (Feb 4, 2019):
Which is kinda weird, considering mx records are defined in hostnames, not IP addresses..?
@tonioo commented on GitHub (Feb 4, 2019):
@tuxis-ie The comparison is done after name resolution.
@kryskool commented on GitHub (Dec 12, 2020):
I think in this case we can add a better error message instead of traceback