[PR #23] [MERGED] Ussd: Add support for new sms_tool option to manually pick PDU decoding scheme #30

New issue

Closed

opened 2026-03-04 12:11:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 12:11:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/4IceG/luci-app-sms-tool-js/pull/23
Author: @kylex2
Created: 7/25/2024
Status: ✅ Merged
Merged: 7/25/2024
Merged by: @4IceG

Base: main ← Head: ussd

📝 Commits (4)

a3fed29 Try to unify indentation a bit. No code changes.
2206eb0 sendussd.js: Add missing braces
46b3df7 sendussd.js: refactor handleGo
1038403 ussd: add support for new sms_tool option -c for manually selecting PDU decoding scheme

📊 Changes

2 files changed (+199 additions, -284 deletions)

View changed files

📝 luci-app-sms-tool-js/htdocs/luci-static/resources/view/modem/sendussd.js (+164 -250)
📝 luci-app-sms-tool-js/htdocs/luci-static/resources/view/modem/smsconfig.js (+35 -34)

📄 Description

Hi,

I had issues with decoding USSD replies. The maintainer of sms_tool added an option to manually select the USSD decoding scheme. Please see: github.com/obsy/sms_tool@fce2b931c8. This pull request adds support for this. Let me know what you think.

Thanks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/4IceG/luci-app-sms-tool-js/pull/23 **Author:** [@kylex2](https://github.com/kylex2) **Created:** 7/25/2024 **Status:** ✅ Merged **Merged:** 7/25/2024 **Merged by:** [@4IceG](https://github.com/4IceG) **Base:** `main` ← **Head:** `ussd` --- ### 📝 Commits (4) - [`a3fed29`](https://github.com/4IceG/luci-app-sms-tool-js/commit/a3fed29e8b589cb3850eef2a42382db5f08bc58c) Try to unify indentation a bit. No code changes. - [`2206eb0`](https://github.com/4IceG/luci-app-sms-tool-js/commit/2206eb06fac3c2c1eb9a16c6c70a0a01fb7aa745) sendussd.js: Add missing braces - [`46b3df7`](https://github.com/4IceG/luci-app-sms-tool-js/commit/46b3df75316acb3fce964d1a56938219ac933e02) sendussd.js: refactor handleGo - [`1038403`](https://github.com/4IceG/luci-app-sms-tool-js/commit/10384032a436e63931a9d3a3a99238d13cf68cbf) ussd: add support for new sms_tool option -c for manually selecting PDU decoding scheme ### 📊 Changes **2 files changed** (+199 additions, -284 deletions) <details> <summary>View changed files</summary> 📝 `luci-app-sms-tool-js/htdocs/luci-static/resources/view/modem/sendussd.js` (+164 -250) 📝 `luci-app-sms-tool-js/htdocs/luci-static/resources/view/modem/smsconfig.js` (+35 -34) </details> ### 📄 Description Hi, I had issues with decoding USSD replies. The maintainer of sms_tool added an option to manually select the USSD decoding scheme. Please see: https://github.com/obsy/sms_tool/commit/fce2b931c8d749c28b8281363950e963c98324eb. This pull request adds support for this. Let me know what you think. Thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>