mirror of
https://github.com/4IceG/luci-app-sms-tool-js.git
synced 2026-04-26 03:15:59 +03:00
[GH-ISSUE #22] no indication of ongoing sms deletion process #17
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/luci-app-sms-tool-js#17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bam80 on GitHub (Jul 24, 2024).
Original GitHub issue: https://github.com/4IceG/luci-app-sms-tool-js/issues/22
If many SMS messages are deleting, the process seems takes time, but there is no indication if it's ongoing yet or finished.
Messages count slowly decreases but this easily can be unnoticed.
If in the middle of the deletion process one presses "Refresh messages" button, the deletion stops.
This behavior confused me until I didn't find out what's going on here.
@4IceG commented on GitHub (Jul 24, 2024):
A progress bar and a changing counter inform you about the progress of SMS deletion process.
I have no influence on how the modem reacts to command to delete messages.
Question... who deletes and refreshes messages at the same time.
Tip: Don't delete 1000 messages at once, you will hang up modem.
@bam80 commented on GitHub (Jul 24, 2024):
I see no progress bar on my side, and as I said changing counter is not helping here as it's unnoticeable.
I delete just few tens of the messages, and yet got the problem.
Let's please reopen as it's clear issue here.
@4IceG commented on GitHub (Jul 24, 2024):
I won't change it because it works for me (on my routers).
Another thing is that you are using a non standard theme (since you don't see the bar?) and your modem hangs when deleting a larger number of SMS (since the counter does not change).
@bam80 commented on GitHub (Jul 24, 2024):
Thanks for reopening.
If you mean this bar, it doesn't help for tracking the deletion process, as it's not clear when it starts and ends:
I use luci-app-sms-tool-js 2.0.23-20240622.
If there is another bar:
I'm not using anything non-standard and my modem doesn't hang, since the counter (on the screenshot) does change but it's simply unhelpful for the deletion process notion.
As an idea, some kind of additional (modal?) popup bar when the deletion starts would do the trick:
it could be full from the start and represent messages count to be deleted, with the decreasing counter. After that, it could fully disappear.
@4IceG commented on GitHub (Jul 25, 2024):
@bam80 Now you know what is missing in my package and what other SMS packages have, you can add missing functionality.
Writing a few lines of code in LuCI JS is trivial (probably).
At the moment, modifying package is not in my priorities, so you submit a PR with your own code or wait patiently.