mirror of
https://github.com/4IceG/luci-app-atinout-mod.git
synced 2026-04-26 10:35:49 +03:00
[GH-ISSUE #17] populate /etc/atcommands.user with more commands #17
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/luci-app-atinout-mod#17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bam80 on GitHub (Aug 9, 2023).
Original GitHub issue: https://github.com/4IceG/luci-app-atinout-mod/issues/17
I see on the screenshot the file is populated with a lot of useful commands.
Forcing the user to fill all that by hand is probably not very kind.
Could we ship these commands in the app distribution?
I know they might be modem-specific, but still it's easier to remove excessive than add non-existent ones, IMO.
@4IceG commented on GitHub (Aug 10, 2023):
I have not added a list of commands so that inexperienced users do not damage the modem by accidentally clicking it.
I can add my list of commands on github, but I don't know if it makes sense. I only use one modem manufacturer.
@bam80 commented on GitHub (Jan 15, 2024):
We could add sane commands in this list, as
ATIand such.Anyway, could you add your list in text format somewhere, please?
That could be e.g.
/etc/atcommands.user.sampleincluded in the package, so users could adopt it easily.@4IceG commented on GitHub (Jan 15, 2024):
Hi @bam80 ,
I added an example/my list of at commands to the readme for the package https://github.com/4IceG/luci-app-atcommands. I haven't used atinout for a long time, so I haven't updated readme or the package.
I don't want to add sample files to package because then I read comments on the Internet so that users don't stupidly click on the commands from the list.
@bam80 commented on GitHub (Jan 15, 2024):
Thanks, but how about including the
/etc/atcommands.user.samplefile to the package?That way users are responsible if they renaming it to the actual one, and it's still easier to adopt.
@4IceG commented on GitHub (Jan 15, 2024):
It's safe for me not to add anything.
I assume that users are reasonable and will consider adding useful commands to their list.
@bam80 commented on GitHub (Jan 15, 2024):
I had hard times to acquire that list, and even now when you published it it's hidden quite a lot.
I wouldn't arise the issue if it was not problematic on practice.