[PR #827] [MERGED] server: Fix panic due to database collation #976

New issue

Closed

opened 2026-02-27 09:10:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:10:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/827
Author: @nitnelave
Created: 2/2/2024
Status: ✅ Merged
Merged: 2/2/2024
Merged by: @nitnelave

Base: main ← Head: filters

📝 Commits (1)

d8c5725 server: Fix panic due to database collation

📊 Changes

2 files changed (+49 additions, -48 deletions)

View changed files

📝 server/src/domain/sql_group_backend_handler.rs (+24 -24)
📝 server/src/domain/sql_user_backend_handler.rs (+25 -24)

📄 Description

When the database's collation is not "C", the DB order is not the same as the Rust order. As such, asserting that the elements are in increasing order fails. However, since both queries get the order from the database, they should be in the same order.

With too many users, the query had a giant filter IN (u1, u2, u3, ...). In PostgreSQL, we can pass the users as an array instead, but that doesn't work with SQLite. Instead, we repeat the filter from the previous query to get the same users/groups, as a subquery.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/827 **Author:** [@nitnelave](https://github.com/nitnelave) **Created:** 2/2/2024 **Status:** ✅ Merged **Merged:** 2/2/2024 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `filters` --- ### 📝 Commits (1) - [`d8c5725`](https://github.com/lldap/lldap/commit/d8c572554a0938127e83af6072a8fee0dd4e231a) server: Fix panic due to database collation ### 📊 Changes **2 files changed** (+49 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/sql_group_backend_handler.rs` (+24 -24) 📝 `server/src/domain/sql_user_backend_handler.rs` (+25 -24) </details> ### 📄 Description When the database's collation is not "C", the DB order is not the same as the Rust order. As such, asserting that the elements are in increasing order fails. However, since both queries get the order from the database, they should be in the same order. With too many users, the query had a giant filter `IN (u1, u2, u3, ...)`. In PostgreSQL, we can pass the users as an array instead, but that doesn't work with SQLite. Instead, we repeat the filter from the previous query to get the same users/groups, as a subquery. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>