[PR #567] [MERGED] tests: allow dead code in common module #827

Closed
opened 2026-02-27 09:09:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/567
Author: @nitnelave
Created: 5/2/2023
Status: Merged
Merged: 5/2/2023
Merged by: @nitnelave

Base: mainHead: vtolmer/clippy


📝 Commits (2)

  • 6144d4b tests: allow dead code in common module
  • d6c996f docker: ignore more files

📊 Changes

2 files changed (+10 additions, -3 deletions)

View changed files

📝 .dockerignore (+9 -1)
📝 server/tests/common/env.rs (+1 -2)

📄 Description

We're running afoul of https://github.com/rust-lang/rust/issues/46379, where each test is compiled independently, so any test that doesn't use every helper method triggers a dead code warning.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/567 **Author:** [@nitnelave](https://github.com/nitnelave) **Created:** 5/2/2023 **Status:** ✅ Merged **Merged:** 5/2/2023 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `vtolmer/clippy` --- ### 📝 Commits (2) - [`6144d4b`](https://github.com/lldap/lldap/commit/6144d4b70733d3b5b2431151bf1f1416d0488a4f) tests: allow dead code in common module - [`d6c996f`](https://github.com/lldap/lldap/commit/d6c996f2c2d3b67c9d4b46bed4017e1798e3c322) docker: ignore more files ### 📊 Changes **2 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+9 -1) 📝 `server/tests/common/env.rs` (+1 -2) </details> ### 📄 Description We're running afoul of https://github.com/rust-lang/rust/issues/46379, where each test is compiled independently, so any test that doesn't use every helper method triggers a dead code warning. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 09:09:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/lldap-lldap#827
No description provided.