[PR #402] [MERGED] Add devcontainer #717

New issue

Closed

opened 2026-02-27 09:09:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:09:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/402
Author: @pixelrazor
Created: 12/31/2022
Status: ✅ Merged
Merged: 1/3/2023
Merged by: @nitnelave

Base: main ← Head: feature/dev-container

📝 Commits (5)

3a559ec Add devcontainer
05f4dfe Remove extra paarts from devcontainer config
4061506 Add user for correct file perms
d425305 update ignore files
27d3765 missed dir in dockerignore

📊 Changes

4 files changed (+36 additions, -0 deletions)

View changed files

➕ .devcontainer/Dockerfile (+26 -0)
➕ .devcontainer/devcontainer.json (+5 -0)
📝 .dockerignore (+4 -0)
📝 .gitignore (+1 -0)

📄 Description

Fixes #331
The dockerfile could probably be optimized - i just tinkered until i got something that wants to work out the box. the cargo install step is pretty hefty, so i COULD try to tinker with making that a separate layer as early as possible to help cache it, but i don't think it's too important given this shouldn't change often at all.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/402 **Author:** [@pixelrazor](https://github.com/pixelrazor) **Created:** 12/31/2022 **Status:** ✅ Merged **Merged:** 1/3/2023 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `feature/dev-container` --- ### 📝 Commits (5) - [`3a559ec`](https://github.com/lldap/lldap/commit/3a559ec11266fd756fbf66160fcf12a8889c9724) Add devcontainer - [`05f4dfe`](https://github.com/lldap/lldap/commit/05f4dfee1e0809df0ae0f8967ae3027ade145011) Remove extra paarts from devcontainer config - [`4061506`](https://github.com/lldap/lldap/commit/40615067cf272788de6d9d6a889fcd2b88e5c212) Add user for correct file perms - [`d425305`](https://github.com/lldap/lldap/commit/d4253056bdd1a2a12fc9226e55befa9cdecc7f98) update ignore files - [`27d3765`](https://github.com/lldap/lldap/commit/27d37650caf16bc098e80d2444c2a7a19bfd9021) missed dir in dockerignore ### 📊 Changes **4 files changed** (+36 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.devcontainer/Dockerfile` (+26 -0) ➕ `.devcontainer/devcontainer.json` (+5 -0) 📝 `.dockerignore` (+4 -0) 📝 `.gitignore` (+1 -0) </details> ### 📄 Description Fixes #331 The dockerfile could probably be optimized - i just tinkered until i got something that wants to work out the box. the cargo install step is pretty hefty, so i COULD try to tinker with making that a separate layer as early as possible to help cache it, but i don't think it's too important given this shouldn't change often at all. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>