mirror of
https://github.com/lldap/lldap.git
synced 2026-04-25 08:15:52 +03:00
[GH-ISSUE #1128] [BUG] The default password in the docker compose example has wrong syntax #402
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#402
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @garylavayou on GitHub (Mar 14, 2025).
Original GitHub issue: https://github.com/lldap/lldap/issues/1128
Describe the bug
In the project's README file, in the docker compose example, the
LLDAP_LDAP_USER_PASS=adminPas$wordwill be parsed asadminPas, due to$wordbeing treated as a compose environment variable, which is not defined and thus empty.This is misleading and frustrating for a user who want to get started with lldap, as the person may not recognize that the real password is
adminPas. When the service is up, he/she will useadminPas$wordas password to login asadmin, which results in failure as the password does not match.Expected behavior
Using
$$to escape$in the compose file, i.e., updateLLDAP_LDAP_USER_PASS=adminPas$wordasLLDAP_LDAP_USER_PASS=adminPas$$word.@nitnelave commented on GitHub (Mar 14, 2025):
I'm sorry, I lack a bit of empathy for people who use default passwords :D
I think your suggestion still fails the usability test, since users will now think that the password is "pas$$word". I would rather put "CHANGE_ME" as the password.
Do you think you could open a PR to fix the example?
@garylavayou commented on GitHub (Mar 15, 2025):
yes, I will create a PR later.
By the way, is there any requirements on the password complexity. Maybe we can demonstrate it using some other special characters.
@nitnelave commented on GitHub (Mar 19, 2025):
There are no requirements (and cannot be, since when changing the password the server doesn't receive the plaintext password).
There are some proposals to have the frontend "enforce" rules (that a motivated user could bypass) and the server enforce the same on the LDAP interface, but nothing concrete yet.
@NassimBounouas commented on GitHub (Oct 18, 2025):
Thanks @nitnelave for the merge 🙏 Following the PR, I think this issue can be closed.