[PR #593] [MERGED] Handle corrupt cache files #986

New issue

Closed

opened 2026-02-27 20:00:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/593
Author: @Johannesd3
Created: 2/2/2021
Status: ✅ Merged
Merged: 2/9/2021
Merged by: @sashahilton00

Base: dev ← Head: fix-issue-591

📝 Commits (4)

3446864 Handle corrupt cache files (#591)
f67ceb5 Small refactoring
d3495cf Re-add support for Rust 1.40
2f660f7 Small refactor

📊 Changes

3 files changed (+56 additions, -12 deletions)

View changed files

📝 audio/src/fetch.rs (+7 -0)
📝 core/src/cache.rs (+13 -0)
📝 playback/src/player.rs (+36 -12)

📄 Description

Fixes #591.

If an VorbisError occurs while opening a cached file, the cache file will be deleted and the track will be loaded again.

I also refactored a piece of code above my fix which didn't make sense to me. The warning <{}> in not available in format {:?} would never occur, would it?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/593 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 2/2/2021 **Status:** ✅ Merged **Merged:** 2/9/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `fix-issue-591` --- ### 📝 Commits (4) - [`3446864`](https://github.com/librespot-org/librespot/commit/34468648381fefacafb3ae47640c9b70b5a59437) Handle corrupt cache files (#591) - [`f67ceb5`](https://github.com/librespot-org/librespot/commit/f67ceb5f6d955c800564a98f8a4098c7702e8083) Small refactoring - [`d3495cf`](https://github.com/librespot-org/librespot/commit/d3495cfed4150a021b53b84f8c3ddeb17315dfd5) Re-add support for Rust 1.40 - [`2f660f7`](https://github.com/librespot-org/librespot/commit/2f660f74ecf66bc15cf18ea7bf317ed3a942eb8d) Small refactor ### 📊 Changes **3 files changed** (+56 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/fetch.rs` (+7 -0) 📝 `core/src/cache.rs` (+13 -0) 📝 `playback/src/player.rs` (+36 -12) </details> ### 📄 Description Fixes #591. If an `VorbisError` occurs while opening a cached file, the cache file will be deleted and the track will be loaded again. I also refactored a piece of code above my fix which didn't make sense to me. The warning `<{}> in not available in format {:?}` would never occur, would it? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:43 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:28 +03:00

[PR #986] [MERGED] Remove the volume sample iteration #1175

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#986

No description provided.

Rows
Columns