[PR #986] [MERGED] Remove the volume sample iteration #1175

New issue

Closed

opened 2026-02-27 20:01:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/986
Author: @JasonLG1979
Created: 4/18/2022
Status: ✅ Merged
Merged: 5/19/2022
Merged by: @roderickvd

Base: dev ← Head: roll-in-volume

📝 Commits (5)

f81b4d4 Remove the volume sample iteration
0a81fa0 Rename some things.
d640c49 Create a NoOp soft volume
11d4aae fix example
5d8d9de clarify naming

📊 Changes

5 files changed (+122 additions, -121 deletions)

View changed files

📝 examples/play.rs (+2 -1)
📝 playback/src/mixer/mod.rs (+12 -4)
📝 playback/src/mixer/softmixer.rs (+7 -16)
📝 playback/src/player.rs (+99 -98)
📝 src/main.rs (+2 -2)

📄 Description

Move volume calculations out of their own separate samples iteration and into the normalisation iteration.

I plan on doing this and more in the new API branch. This bit was just a quick and easy backport that really don't change much at all. Further work on the new API branch may get backports or not depending on if/when 0.4 is released, as anything after 0.4 can't break the 0.4 API.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/986 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 4/18/2022 **Status:** ✅ Merged **Merged:** 5/19/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `roll-in-volume` --- ### 📝 Commits (5) - [`f81b4d4`](https://github.com/librespot-org/librespot/commit/f81b4d4fbd1b1680a94de81f5aed5f4daffb7622) Remove the volume sample iteration - [`0a81fa0`](https://github.com/librespot-org/librespot/commit/0a81fa0842b8c9a57557aa6991071756da8a069f) Rename some things. - [`d640c49`](https://github.com/librespot-org/librespot/commit/d640c4968ac616275cc826b86bd222b3c70a0245) Create a NoOp soft volume - [`11d4aae`](https://github.com/librespot-org/librespot/commit/11d4aae45c27583f4e2e37cb154a5031fa430216) fix example - [`5d8d9de`](https://github.com/librespot-org/librespot/commit/5d8d9defe1c669a850e71f3133f92e55e80675e0) clarify naming ### 📊 Changes **5 files changed** (+122 additions, -121 deletions) <details> <summary>View changed files</summary> 📝 `examples/play.rs` (+2 -1) 📝 `playback/src/mixer/mod.rs` (+12 -4) 📝 `playback/src/mixer/softmixer.rs` (+7 -16) 📝 `playback/src/player.rs` (+99 -98) 📝 `src/main.rs` (+2 -2) </details> ### 📄 Description Move volume calculations out of their own separate samples iteration and into the normalisation iteration. I plan on doing this and more in the new API branch. This bit was just a quick and easy backport that really don't change much at all. Further work on the new API branch may get backports or not depending on if/when 0.4 is released, as anything after 0.4 can't break the 0.4 API. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:28 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:46 +03:00

[PR #1175] [MERGED] Bump actions/checkout from 3.5.2 to 3.5.3 #1262

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1175

No description provided.

Rows
Columns